Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 608593007: Change chrome_tests.py to run 'run-webkit-tests' script. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, Timur Iskhodzhanov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change chrome_tests.py to run 'run-webkit-tests' script. Instead of going through the Chromium's script 'run_webkit_tests.py' that lives in webkit/tools/layout_tests and it is just a wrapper around 'run-webkit-tests', call the later directly from third_party/WebKit/Tools/Scripts/. As we are removing webkit/ directory, this change is also necessary. BUG=338338 TEST=None R=dpranke@chromium.org,bruening@chromium.org Committed: https://crrev.com/b62734424a2b90ccf2bdb11a874f774fb15cccaf Cr-Commit-Position: refs/heads/master@{#297467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/valgrind/chrome_tests.py View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
This is the last reference I found with 'git grep run_webkit'. PTAL.
6 years, 2 months ago (2014-09-27 02:18:41 UTC) #1
Dirk Pranke
lgtm
6 years, 2 months ago (2014-09-27 02:30:46 UTC) #2
Timur Iskhodzhanov
thestig@ might want to review this. Oh, he's OOO and I can't add him to ...
6 years, 2 months ago (2014-09-30 09:19:18 UTC) #4
Alexander Potapenko
On 2014/09/30 09:19:18, Timur Iskhodzhanov wrote: > thestig@ might want to review this. Oh, he's ...
6 years, 2 months ago (2014-09-30 09:21:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608593007/1
6 years, 2 months ago (2014-09-30 17:52:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 035c16bad2c8db4e61ff80906052b86f5af248b6
6 years, 2 months ago (2014-09-30 18:57:21 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:58:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b62734424a2b90ccf2bdb11a874f774fb15cccaf
Cr-Commit-Position: refs/heads/master@{#297467}

Powered by Google App Engine
This is Rietveld 408576698