gn format: don't crash when there's no block on a function call

gn format: don't crash when there's no block on a function call

(Child of https://codereview.chromium.org/607173002/)

R=brettw@chromium.org
BUG=348474
Committed: https://crrev.com/c5e6f0acd2b1e1a44f8919c85dccf21fb4ca1aaf
Cr-Commit-Position: refs/heads/master@{#297228}

[brettw, 2014-09-26 23:50:29]

lgtm

[scottmg, 2014-09-27 00:29:23]

Thanks, need https://codereview.chromium.org/607173002/ first though. :)

[tfarina, 2014-09-27 00:57:55]

This fixes this crash?

Program received signal SIGSEGV, Segmentation fault.
0x00000000004dfe1b in commands::(anonymous namespace)::Printer::Block
(this=0x7fffffffcc00, root=0x0) at ../../tools/gn/command_format.cc:148
148	  const BlockNode* block = root->AsBlock();

It is crashing in almost any BUILD.gn file I tried in ui/.

Looking forward to try your CL once it lands ;)

[scottmg, 2014-09-27 01:29:50]

Yeah, I was dumb, any import() will fail, because it's assuming there's a
{} block after it.

On Fri, Sep 26, 2014 at 5:57 PM, <tfarina@chromium.org> wrote:

> This fixes this crash?
>
> Program received signal SIGSEGV, Segmentation fault.
> 0x00000000004dfe1b in commands::(anonymous namespace)::Printer::Block
> (this=0x7fffffffcc00, root=0x0) at ../../tools/gn/command_format.cc:148
> 148       const BlockNode* block = root->AsBlock();
>
> It is crashing in almost any BUILD.gn file I tried in ui/.
>
> Looking forward to try your CL once it lands ;)
>
>
> https://codereview.chromium.org/608593006/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2014-09-29 19:27:24]

Committed patchset #2 (id:20001) manually as
c5e6f0acd2b1e1a44f8919c85dccf21fb4ca1aaf (presubmit successful).

[commit-bot: I haz the power, 2014-09-29 19:27:24]

Patchset 2 (id:??) landed as
https://crrev.com/c5e6f0acd2b1e1a44f8919c85dccf21fb4ca1aaf
Cr-Commit-Position: refs/heads/master@{#297228}