Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 608573003: Add owners for c/b/ui/views/accessibility (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
tfarina, sky
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add owners for c/b/ui/views/accessibility BUG=none Committed: https://crrev.com/4a414030466b90f7f11795229199c4e975fb4fcd Cr-Commit-Position: refs/heads/master@{#296843}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Upload with --no-find-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A chrome/browser/ui/views/accessibility/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
dmazzoni
6 years, 2 months ago (2014-09-25 18:48:23 UTC) #2
tfarina
I looked at ui/accessibility/OWNERS (https://chromium.googlesource.com/chromium/src/+/master/ui/accessibility/OWNERS). There we have aboxhall instead of plundblad. Do you want ...
6 years, 2 months ago (2014-09-25 19:02:19 UTC) #4
dmazzoni
On 2014/09/25 19:02:19, tfarina wrote: > I looked at ui/accessibility/OWNERS > (https://chromium.googlesource.com/chromium/src/+/master/ui/accessibility/OWNERS). > There we ...
6 years, 2 months ago (2014-09-25 19:14:47 UTC) #5
dmazzoni
https://codereview.chromium.org/608573003/diff/1/chrome/browser/ui/views/accessibility/OWNERS File chrome/browser/ui/views/accessibility/OWNERS (left): https://codereview.chromium.org/608573003/diff/1/chrome/browser/ui/views/accessibility/OWNERS#oldcode1 chrome/browser/ui/views/accessibility/OWNERS:1: dmazzoni@chromium.org On 2014/09/25 19:02:19, tfarina wrote: > could you ...
6 years, 2 months ago (2014-09-25 19:15:15 UTC) #6
sky
LGTM
6 years, 2 months ago (2014-09-25 23:28:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608573003/20001
6 years, 2 months ago (2014-09-25 23:36:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as fe87e38c669431598f513e5d6b6c70ff8d48be37
6 years, 2 months ago (2014-09-26 00:50:26 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 00:51:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a414030466b90f7f11795229199c4e975fb4fcd
Cr-Commit-Position: refs/heads/master@{#296843}

Powered by Google App Engine
This is Rietveld 408576698