Implement mix-blend-mode=screen using glBlendFunc.

Implement mix-blend-mode=screen using glBlendFunc.

This avoids creating a temporary texture for the blending step, and
if there's no background filter also avoids creating the backdrop texture.

BUG=

Committed: https://crrev.com/4388931142e7a999ad6a0820afde47810e050e68
Cr-Commit-Position: refs/heads/master@{#297385}

[Erik Dahlström (inactive), 2014-09-25 16:00:36]

ed@opera.com changed reviewers:
+ danakj@chromium.org, enne@chromium.org

[enne (OOO), 2014-09-26 18:20:37]

https://codereview.chromium.org/608523003/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/608523003/diff/1/cc/output/gl_renderer.cc#new...
cc/output/gl_renderer.cc:703: bool
GLRenderer::ShouldApplyBackgroundFilters(DrawingFrame* frame,
How is this related to this change?

https://codereview.chromium.org/608523003/diff/1/cc/output/gl_renderer.cc#new...
cc/output/gl_renderer.cc:1033: !ShouldApplyBlendModeUsingBlendFunc(quad)) ||
Could you combine ShouldApplyBlendModeUsingBlendFunc and this kSrcOver_Mode
checks everywhere? It seems like you've written a general function but then not
included one of the cases in it.

[Erik Dahlström (inactive), 2014-09-29 08:33:42]

https://codereview.chromium.org/608523003/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/608523003/diff/1/cc/output/gl_renderer.cc#new...
cc/output/gl_renderer.cc:703: bool
GLRenderer::ShouldApplyBackgroundFilters(DrawingFrame* frame,
On 2014/09/26 18:20:36, enne wrote:
> How is this related to this change?

You're right, it's not really related, I'll drop that part.

https://codereview.chromium.org/608523003/diff/1/cc/output/gl_renderer.cc#new...
cc/output/gl_renderer.cc:1033: !ShouldApplyBlendModeUsingBlendFunc(quad)) ||
On 2014/09/26 18:20:36, enne wrote:
> Could you combine ShouldApplyBlendModeUsingBlendFunc and this kSrcOver_Mode
> checks everywhere? It seems like you've written a general function but then
not
> included one of the cases in it.

Done.

[enne (OOO), 2014-09-29 18:25:13]

lgtm

https://codereview.chromium.org/608523003/diff/20001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/608523003/diff/20001/cc/output/gl_renderer.cc...
cc/output/gl_renderer.cc:717: DCHECK(ShouldApplyBlendModeUsingBlendFunc(quad));
I don't think this DCHECK adds much.  Can you remove it and quad from the
interface?

[Erik Dahlström (inactive), 2014-09-30 07:06:07]

https://codereview.chromium.org/608523003/diff/20001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/608523003/diff/20001/cc/output/gl_renderer.cc...
cc/output/gl_renderer.cc:717: DCHECK(ShouldApplyBlendModeUsingBlendFunc(quad));
On 2014/09/29 18:25:13, enne wrote:
> I don't think this DCHECK adds much.  Can you remove it and quad from the
> interface?

Done.

[Erik Dahlström (inactive), 2014-09-30 07:06:16]

The CQ bit was checked by ed@opera.com

[commit-bot: I haz the power, 2014-09-30 07:06:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/608523003/60001

[commit-bot: I haz the power, 2014-09-30 07:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 07:18:14]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/67185)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Erik Dahlström (inactive), 2014-09-30 07:52:30]

The CQ bit was checked by ed@opera.com

[commit-bot: I haz the power, 2014-09-30 07:53:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/608523003/80001

[commit-bot: I haz the power, 2014-09-30 08:52:20]

Committed patchset #5 (id:80001) as 1734ece8c17fe1521e553b83604acecaa0bc5be8

[commit-bot: I haz the power, 2014-09-30 08:52:59]

Patchset 5 (id:??) landed as
https://crrev.com/4388931142e7a999ad6a0820afde47810e050e68
Cr-Commit-Position: refs/heads/master@{#297385}