Add IsGeneratorFunction and IsGeneratorObject checks to v8::Value.

Add IsGeneratorFunction and IsGeneratorObject checks to v8::Value.

R=ulan@chromium.org, yangguo@chromium.org, wingo, yangguo

Committed: https://code.google.com/p/v8/source/detail?r=24278

[Yang, 2014-09-25 14:34:02]

yangguo@chromium.org changed reviewers:
+ ulan@chromium.org, yangguo@chromium.org

[Yang, 2014-09-25 14:34:02]

Would it make sense to have v8::Function::IsGenerator() instead of
v8::Value::IsGeneratorFunction()?

Adding Ulan because this is an API change.

[aandrey, 2014-09-25 14:39:12]

On 2014/09/25 14:34:02, Yang wrote:
> Would it make sense to have v8::Function::IsGenerator() instead of
> v8::Value::IsGeneratorFunction()?
> 
> Adding Ulan because this is an API change.

It's your call.

To me, it's clearer to have the IsGeneratorFunction/IsGeneratorObject pair than
IsGenerator/IsGeneratorObject. I'd guess the latter would make me think which is
what.

[Yang, 2014-09-25 14:44:23]

On 2014/09/25 14:39:12, aandrey wrote:
> On 2014/09/25 14:34:02, Yang wrote:
> > Would it make sense to have v8::Function::IsGenerator() instead of
> > v8::Value::IsGeneratorFunction()?
> > 
> > Adding Ulan because this is an API change.
> 
> It's your call.
> 
> To me, it's clearer to have the IsGeneratorFunction/IsGeneratorObject pair
than
> IsGenerator/IsGeneratorObject. I'd guess the latter would make me think which
is
> what.

Let's keep it this way. The spec does not say that generator functions are
functions, so let's not expose this implementation detail to the API. LGTM.

[Yang, 2014-09-25 14:46:06]

yangguo@chromium.org changed reviewers:
+ rossberg@chromium.org

[ulan, 2014-09-25 14:52:20]

lgtm

[aandrey, 2014-09-29 10:23:04]

Committed patchset #2 (id:20001) manually as 24278 (presubmit successful).