Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 608443002: [src/content <->blink side ] Apply automatic range checks to enum types across IPC . (Closed)

Created:
6 years, 2 months ago by ARUNKK
Modified:
6 years, 2 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[src/content <->blink side ] Apply automatic range checks to enum types across IPC . This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/59f37e9db2c210fd9f7ff2f5628131a5a0d1df03 Cr-Commit-Position: refs/heads/master@{#296878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/common/view_messages.h View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ARUNKK
[src/content <->blink side ] Apply automatic range checks to enum types across IPC . PTAL.
6 years, 2 months ago (2014-09-25 10:39:45 UTC) #2
Tom Sepez
LGTM. Thanks!
6 years, 2 months ago (2014-09-25 19:42:29 UTC) #4
ARUNKK
On 2014/09/25 19:42:29, Tom Sepez wrote: > LGTM. Thanks! Thanks for LGTM.
6 years, 2 months ago (2014-09-26 02:58:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608443002/1
6 years, 2 months ago (2014-09-26 02:59:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8758fe11c8c3ab8444f6bc522e937af5e22b27cb
6 years, 2 months ago (2014-09-26 04:10:33 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 04:11:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59f37e9db2c210fd9f7ff2f5628131a5a0d1df03
Cr-Commit-Position: refs/heads/master@{#296878}

Powered by Google App Engine
This is Rietveld 408576698