Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 608363004: Swarm release Windows 7 x64 tests on main waterfall. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Swarm release Windows 7 x64 tests on main waterfall. I moved all tests to Win Tests x64 (1) in preparation for removing 2 & 3. BUG=414808 R=maruel@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/6ecefe38d8762473839f797a6abb98c5eb66a1b7

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -38 lines) Patch
M testing/buildbot/chromium.win.json View 1 3 chunks +78 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jam
6 years, 2 months ago (2014-09-29 21:59:21 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/608363004/diff/1/testing/buildbot/chromium.win.json File testing/buildbot/chromium.win.json (right): https://codereview.chromium.org/608363004/diff/1/testing/buildbot/chromium.win.json#newcode289 testing/buildbot/chromium.win.json:289: "test": "net_unittests", Move after mojo_system_unittests.
6 years, 2 months ago (2014-09-29 22:07:48 UTC) #3
jam
https://codereview.chromium.org/608363004/diff/1/testing/buildbot/chromium.win.json File testing/buildbot/chromium.win.json (right): https://codereview.chromium.org/608363004/diff/1/testing/buildbot/chromium.win.json#newcode289 testing/buildbot/chromium.win.json:289: "test": "net_unittests", On 2014/09/29 22:07:47, M-A Ruel wrote: > ...
6 years, 2 months ago (2014-09-29 22:36:15 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6ecefe38d8762473839f797a6abb98c5eb66a1b7 Cr-Commit-Position: refs/heads/master@{#297301}
6 years, 2 months ago (2014-09-29 23:26:22 UTC) #5
jam
6 years, 2 months ago (2014-09-29 23:31:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6ecefe38d8762473839f797a6abb98c5eb66a1b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698