Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 60833007: Add ::Leaky to the LazyInstance<SafeBrowsingServiceFactoryImpl> in (Closed)

Created:
7 years, 1 month ago by not at google - send to devlin
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add ::Leaky to the LazyInstance<SafeBrowsingServiceFactoryImpl> in safe_browsing_service.cc. Hopefully this will fix the "pure virtual method called" errors seen in various ExtensionService tests that use safe browsing; both those reverted as part of bug 233290, and the ones that are still live. BUG=233290 R=jyasskin@chromium.org TBR=shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
This is Jeffrey's idea for a fix here. Thanks Jeffrey.
7 years, 1 month ago (2013-11-06 23:22:40 UTC) #1
Jeffrey Yasskin
lgtm with the caveat that this is speculative, based on https://commondatastorage.googleapis.com/chromium-build-logs/logs/2013/11/ahVzfmNocm9taXVtLWJ1aWxkLWxvZ3NyiQELEgVCdWlsZCJvMSAtIGh0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcvcC9jaHJvbWl1bS5saW51eC9qc29uIC0gTGludXggVGVzdHMgKGRiZykoMikoMzIpIC0gNzYwOSAtIDEzODM3NzU1NDAgLSAxMzgzNzc4MDg5DAsSCUJ1aWxkU3RlcBgbDA. I don't see a ...
7 years, 1 month ago (2013-11-06 23:40:00 UTC) #2
not at google - send to devlin
I'm submitting this now in the hope that it does quash some of those flaky ...
7 years, 1 month ago (2013-11-07 00:10:36 UTC) #3
not at google - send to devlin
7 years, 1 month ago (2013-11-07 00:10:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r233426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698