Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/skpdiff/SkImageDiffer.h

Issue 60833002: fix multithread related crashes in skpdiff (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/skpdiff/SkDifferentPixelsMetric_opencl.cpp ('K') | « tools/skpdiff/SkDifferentPixelsMetric_opencl.cpp ('k') | tools/skpdiff/SkPMetric.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/skpdiff/SkImageDiffer.h
diff --git a/tools/skpdiff/SkImageDiffer.h b/tools/skpdiff/SkImageDiffer.h
index 6c570cbb8e41bc3d8437937047f55396cd262258..874bd3de0f64810e5429adc89758e3cf4760ab39 100644
--- a/tools/skpdiff/SkImageDiffer.h
+++ b/tools/skpdiff/SkImageDiffer.h
@@ -91,6 +91,9 @@ public:
protected:
bool fIsGood;
+
+ // Used to ensure that only one thread is able to queue new entries at a time
+ SkMutex fQueueMutex;
mtklein 2013/11/06 14:24:36 Pretty weird to have this on the base class.
};
« tools/skpdiff/SkDifferentPixelsMetric_opencl.cpp ('K') | « tools/skpdiff/SkDifferentPixelsMetric_opencl.cpp ('k') | tools/skpdiff/SkPMetric.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698