Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: tools/skpdiff/SkImageDiffer.cpp

Issue 60833002: fix multithread related crashes in skpdiff (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: opencl and fixes Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/skpdiff/SkImageDiffer.cpp
diff --git a/tools/skpdiff/SkImageDiffer.cpp b/tools/skpdiff/SkImageDiffer.cpp
index 40a34da6b13443f6dbebca48887bba1f9cec63ab..62b1215dfce1f6108de5d8eedef8f94fbe853534 100644
--- a/tools/skpdiff/SkImageDiffer.cpp
+++ b/tools/skpdiff/SkImageDiffer.cpp
@@ -22,17 +22,3 @@ SkImageDiffer::SkImageDiffer()
SkImageDiffer::~SkImageDiffer() {
}
-
-int SkImageDiffer::queueDiffOfFile(const char baseline[], const char test[]) {
- SkBitmap baselineBitmap;
- SkBitmap testBitmap;
- if (!SkImageDecoder::DecodeFile(baseline, &baselineBitmap)) {
- SkDebugf("Failed to load bitmap \"%s\"\n", baseline);
- return -1;
- }
- if (!SkImageDecoder::DecodeFile(test, &testBitmap)) {
- SkDebugf("Failed to load bitmap \"%s\"\n", test);
- return -1;
- }
- return this->queueDiff(&baselineBitmap, &testBitmap);
-}

Powered by Google App Engine
This is Rietveld 408576698