Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: tools/skpdiff/SkDifferentPixelsMetric.h

Issue 60833002: fix multithread related crashes in skpdiff (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: addressing comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkDifferentPixelsMetric_DEFINED 8 #ifndef SkDifferentPixelsMetric_DEFINED
9 #define SkDifferentPixelsMetric_DEFINED 9 #define SkDifferentPixelsMetric_DEFINED
10 10
11 #include "SkTDArray.h" 11 #include "SkTDArray.h"
12 12
13 #if SK_SUPPORT_OPENCL 13 #if SK_SUPPORT_OPENCL
14 #include "SkCLImageDiffer.h" 14 #include "SkCLImageDiffer.h"
15 #else 15 #else
16 #include "SkImageDiffer.h" 16 #include "SkImageDiffer.h"
17 #endif 17 #endif
18 18
19 /** 19 /**
20 * A differ that measures the percentage of different corresponding pixels. If t he two images are 20 * A differ that measures the percentage of different corresponding pixels. If t he two images are
21 * not the same size or have no pixels, the result will always be zero. 21 * not the same size or have no pixels, the result will always be zero.
22 */ 22 */
23 class SkDifferentPixelsMetric : 23 class SkDifferentPixelsMetric :
24 #if SK_SUPPORT_OPENCL 24 #if SK_SUPPORT_OPENCL
25 public SkCLImageDiffer { 25 public SkCLImageDiffer {
26 #else 26 #else
27 public SkImageDiffer { 27 public SkImageDiffer {
28 #endif 28 #endif
29 public: 29 public:
30 SkDifferentPixelsMetric() : fPOIAlphaMask(false) {} 30 virtual const char* getName() const SK_OVERRIDE;
31 31 virtual bool diff(SkBitmap* baseline, SkBitmap* test, bool computeMask,
32 virtual const char* getName() SK_OVERRIDE; 32 Result* result) const SK_OVERRIDE;
33 virtual bool enablePOIAlphaMask() SK_OVERRIDE;
34 virtual int queueDiff(SkBitmap* baseline, SkBitmap* test) SK_OVERRIDE;
35 virtual void deleteDiff(int id) SK_OVERRIDE;
36 virtual bool isFinished(int id) SK_OVERRIDE;
37 virtual double getResult(int id) SK_OVERRIDE;
38 virtual int getPointsOfInterestCount(int id) SK_OVERRIDE;
39 virtual SkIPoint* getPointsOfInterest(int id) SK_OVERRIDE;
40 virtual SkBitmap* getPointsOfInterestAlphaMask(int id) SK_OVERRIDE;
41 33
42 protected: 34 protected:
43 #if SK_SUPPORT_OPENCL 35 #if SK_SUPPORT_OPENCL
44 virtual bool onInit() SK_OVERRIDE; 36 virtual bool onInit() SK_OVERRIDE;
45 #endif 37 #endif
46 38
47 private: 39 private:
48 bool fPOIAlphaMask;
49
50 struct QueuedDiff;
51 SkTDArray<QueuedDiff> fQueuedDiffs;
52
53 #if SK_SUPPORT_OPENCL 40 #if SK_SUPPORT_OPENCL
54 cl_kernel fKernel; 41 cl_kernel fKernel;
55 42
56 typedef SkCLImageDiffer INHERITED; 43 typedef SkCLImageDiffer INHERITED;
57 #else 44 #else
58 typedef SkImageDiffer INHERITED; 45 typedef SkImageDiffer INHERITED;
59 #endif 46 #endif
60 }; 47 };
61 48
62 #endif 49 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698