fix multithread related crashes in skpdiff

tools/skpdiff/SkDiffContext.h

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkDiffContext_DEFINED
 #define SkDiffContext_DEFINED
 
+#include "SkThread.h"
 #include "SkString.h"
 #include "SkTArray.h"
 #include "SkTDArray.h"
+#include "SkTLList.h"
 
 class SkWStream;
 class SkImageDiffer;
 
 /**
  * Collects records of diffs and outputs them as JSON.
  */
 class SkDiffContext {
 public:
     SkDiffContext();
@@ skipping 79 matching lines @@
         const char* fDiffName;
         double fResult;
         SkTDArray<SkIPoint> fPointsOfInterest;
     };
 
     struct DiffRecord {
         SkString           fDifferencePath;
         SkString           fBaselinePath;
         SkString               fTestPath;
         SkTArray<DiffData>        fDiffs;
-        DiffRecord*                fNext;
     };
 
+    // This is needed to work around a bug in the multithreaded case where the
+    // image decoders are crashing when large numbers of threads are invoking
+    // the decoder at the same time.
+    SkMutex fImageMutex;

[scroggo, 2013/11/05 21:08:52]

Could you create a bug add a link to it here?

+
+    // Used to protect access to fRecords and ensure only one thread is
+    // adding new entries and/or iterating over the existing entries at a time
+    SkMutex fRecordMutex;
+
     // We use linked list for the records so that their pointers remain stable. A resizable array
     // might change its pointers, which would make it harder for async diffs to record their
     // results.
-    DiffRecord * fRecords;
+    SkTLList<DiffRecord> fRecords;
 
     SkImageDiffer** fDiffers;
     int fDifferCount;
     int fThreadCount;
 };
 
 #endif