Issue 608293002: GN Doc fix. Visibility default is public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 608293002: GN Doc fix. Visibility default is public. (Closed)

Created:
6 years, 2 months ago by scheib

Modified:
6 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr

Project:
chromium

Visibility:
Public.

GN Doc fix. Visibility default is public. See Visibility::FillItemVisibility for code implementing default. Committed: https://crrev.com/f95e7311714edec076c4c32b052043f9d4097256 Cr-Commit-Position: refs/heads/master@{#297237}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/gn/variables.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608293002/1

6 years, 2 months ago (2014-09-29 18:37:43 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 024cf88d67d4a2c2480392991b5e2a2f2d553de7

6 years, 2 months ago (2014-09-29 19:39:30 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 19:40:18 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f95e7311714edec076c4c32b052043f9d4097256
Cr-Commit-Position: refs/heads/master@{#297237}