Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

Issue 608283003: Remove retail mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
index 9ff18b76fa52e620bc624659a529ad5310961d73..44c98f49704ea79bf497fb34f58c3083c6b0d89f 100644
--- a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
@@ -10,10 +10,11 @@
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/browser_process_platform_part.h"
-#include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.h"
#include "chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen_actor.h"
#include "chrome/browser/chromeos/login/enrollment/enrollment_screen_actor.h"
#include "chrome/browser/chromeos/login/screens/error_screen.h"
+#include "chrome/browser/chromeos/login/ui/login_display_host.h"
+#include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
#include "chrome/browser/chromeos/login/wizard_controller.h"
#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
#include "chrome/browser/chromeos/policy/consumer_management_service.h"
@@ -76,7 +77,6 @@ const char kStringsJSPath[] = "strings.js";
const char kLoginJSPath[] = "login.js";
const char kOobeJSPath[] = "oobe.js";
const char kKeyboardUtilsJSPath[] = "keyboard_utils.js";
-const char kDemoUserLoginJSPath[] = "demo_user_login.js";
const char kCustomElementsHTMLPath[] = "custom_elements.html";
const char kCustomElementsJSPath[] = "custom_elements.js";
@@ -99,11 +99,6 @@ content::WebUIDataSource* CreateOobeUIDataSource(
source->AddLocalizedStrings(localized_strings);
source->SetJsonPath(kStringsJSPath);
- if (chromeos::KioskModeSettings::Get()->IsKioskModeEnabled()) {
- source->SetDefaultResource(IDR_DEMO_USER_LOGIN_HTML);
- source->AddResourcePath(kDemoUserLoginJSPath, IDR_DEMO_USER_LOGIN_JS);
- return source;
- }
if (display_type == OobeUI::kOobeDisplay) {
source->SetDefaultResource(IDR_OOBE_HTML);
source->AddResourcePath(kOobeJSPath, IDR_OOBE_JS);
@@ -573,13 +568,21 @@ void OobeUI::ShowOobeUI(bool show) {
core_handler_->ShowOobeUI(show);
}
-void OobeUI::ShowRetailModeLoginSpinner() {
- signin_screen_handler_->ShowRetailModeLoginSpinner();
-}
-
void OobeUI::ShowSigninScreen(const LoginScreenContext& context,
SigninScreenHandlerDelegate* delegate,
NativeWindowDelegate* native_window_delegate) {
+ // Check our device mode.
+ if (g_browser_process) {
bartfab (slow) 2014/12/02 21:25:27 When do we run into |g_browser_process == nullptr|
rkc 2014/12/04 19:50:07 Done.
+ policy::BrowserPolicyConnectorChromeOS* connector =
+ g_browser_process->platform_part()->browser_policy_connector_chromeos();
+ if (connector->GetDeviceMode() == policy::DEVICE_MODE_LEGACY_RETAIL_MODE) {
bartfab (slow) 2014/12/02 21:25:27 Nit: #include "components/policy/core/common/cloud
rkc 2014/12/04 19:50:07 Done.
+ // If we're in legacy retail mode, the best thing we can do is launch the
+ // new offline demo mode.
+ LoginDisplayHost* host = LoginDisplayHostImpl::default_host();
bartfab (slow) 2014/12/02 21:25:27 Nit 1: #include "chrome/browser/chromeos/login/ui/
rkc 2014/12/04 19:50:07 Already included.
+ host->StartDemoAppLaunch();
+ }
bartfab (slow) 2014/12/02 21:25:27 Return.
rkc 2014/12/04 19:50:07 Done.
+ }
+
signin_screen_handler_->SetDelegate(delegate);
signin_screen_handler_->SetNativeWindowDelegate(native_window_delegate);

Powered by Google App Engine
This is Rietveld 408576698