src/gpu/effects/GrSimpleTextureEffect.cpp - Issue 608253002: Add isSingleComponent bool to getConstantColorComponent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrSimpleTextureEffect.cpp

Issue 608253002: Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update comment and nits Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrSimpleTextureEffect.cpp

diff --git a/src/gpu/effects/GrSimpleTextureEffect.cpp b/src/gpu/effects/GrSimpleTextureEffect.cpp

index 6743ddbbe1119d5647ed9104077120c234515fb4..84102f1a19527604fa7926d8721e8fe297e9152d 100644

--- a/src/gpu/effects/GrSimpleTextureEffect.cpp

+++ b/src/gpu/effects/GrSimpleTextureEffect.cpp

@@ -41,8 +41,9 @@ private:

///////////////////////////////////////////////////////////////////////////////

-void GrSimpleTextureEffect::getConstantColorComponents(GrColor* color, uint32_t* validFlags) const {

- this->updateConstantColorComponentsForModulation(color, validFlags);

+void GrSimpleTextureEffect::onComputeInvarientOutput(InvarientOutput* invarientOutput) const {

+ this->updateInvarientOutputForModulation(invarientOutput);

+ invarientOutput->isSingleComponent = false;

}

const GrBackendFragmentProcessorFactory& GrSimpleTextureEffect::getFactory() const {