src/gpu/effects/GrConvexPolyEffect.h - Issue 608253002: Add isSingleComponent bool to getConstantColorComponent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrConvexPolyEffect.h

Issue 608253002: Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update comment and nits Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrConvexPolyEffect.h

diff --git a/src/gpu/effects/GrConvexPolyEffect.h b/src/gpu/effects/GrConvexPolyEffect.h

index e4749390a4a3e222c198fb956ab38ea66b4b73b4..f0496462b2d83a7b09e2e8cd97506b33a129b3de 100644

--- a/src/gpu/effects/GrConvexPolyEffect.h

+++ b/src/gpu/effects/GrConvexPolyEffect.h

@@ -70,8 +70,6 @@ public:

typedef GrGLConvexPolyEffect GLProcessor;

- virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags) const SK_OVERRIDE;

virtual const GrBackendFragmentProcessorFactory& getFactory() const SK_OVERRIDE;

private:

@@ -79,6 +77,8 @@ private:

virtual bool onIsEqual(const GrProcessor& other) const SK_OVERRIDE;

+ virtual void onComputeInvarientOutput(InvarientOutput* invarientOutput) const SK_OVERRIDE;

GrPrimitiveEdgeType fEdgeType;

int fEdgeCount;

SkScalar fEdges[3 * kMaxEdges];