Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: src/gpu/GrOvalRenderer.cpp

Issue 608253002: Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Update comment and nits Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/GrOvalRenderer.cpp
diff --git a/src/gpu/GrOvalRenderer.cpp b/src/gpu/GrOvalRenderer.cpp
index 4ae0ebc7efafc1089ea2e568c217d6d7240ca3d0..b4b848b6e97512227fa8a82278ca6f25333eed42 100644
--- a/src/gpu/GrOvalRenderer.cpp
+++ b/src/gpu/GrOvalRenderer.cpp
@@ -75,11 +75,6 @@ public:
}
}
- virtual void getConstantColorComponents(GrColor* color,
- uint32_t* validFlags) const SK_OVERRIDE {
- *validFlags = 0;
- }
-
const GrShaderVar& inCircleEdge() const { return fInCircleEdge; }
virtual const GrBackendGeometryProcessorFactory& getFactory() const SK_OVERRIDE {
@@ -150,6 +145,11 @@ private:
return cee.fStroke == fStroke;
}
+ virtual void onComputeInvarientOutput(InvarientOutput* invarientOutput) const SK_OVERRIDE {
+ invarientOutput->validFlags = 0;
+ invarientOutput->isSingleComponent = false;
+ }
+
const GrShaderVar& fInCircleEdge;
bool fStroke;
@@ -192,11 +192,6 @@ public:
}
}
- virtual void getConstantColorComponents(GrColor* color,
- uint32_t* validFlags) const SK_OVERRIDE {
- *validFlags = 0;
- }
-
virtual const GrBackendGeometryProcessorFactory& getFactory() const SK_OVERRIDE {
return GrTBackendGeometryProcessorFactory<EllipseEdgeEffect>::getInstance();
}
@@ -291,6 +286,11 @@ private:
return eee.fStroke == fStroke;
}
+ virtual void onComputeInvarientOutput(InvarientOutput* invarientOutput) const SK_OVERRIDE {
+ invarientOutput->validFlags = 0;
+ invarientOutput->isSingleComponent = false;
+ }
+
const GrShaderVar& fInEllipseOffset;
const GrShaderVar& fInEllipseRadii;
bool fStroke;
@@ -341,11 +341,6 @@ public:
}
}
- virtual void getConstantColorComponents(GrColor* color,
- uint32_t* validFlags) const SK_OVERRIDE {
- *validFlags = 0;
- }
-
virtual const GrBackendGeometryProcessorFactory& getFactory() const SK_OVERRIDE {
return GrTBackendGeometryProcessorFactory<DIEllipseEdgeEffect>::getInstance();
}
@@ -460,6 +455,11 @@ private:
return eee.fMode == fMode;
}
+ virtual void onComputeInvarientOutput(InvarientOutput* invarientOutput) const SK_OVERRIDE {
+ invarientOutput->validFlags = 0;
+ invarientOutput->isSingleComponent = false;
+ }
+
const GrShaderVar& fInEllipseOffsets0;
const GrShaderVar& fInEllipseOffsets1;
Mode fMode;

Powered by Google App Engine
This is Rietveld 408576698