Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2194)

Unified Diff: src/effects/SkLumaColorFilter.cpp

Issue 608253002: Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Update comment and nits Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/effects/SkLumaColorFilter.cpp
diff --git a/src/effects/SkLumaColorFilter.cpp b/src/effects/SkLumaColorFilter.cpp
index ee2bfa654ccefe5529cef610c38112ec1f309016..4ed789aaae49b4bde30f91977feb4f6546cd02ee 100644
--- a/src/effects/SkLumaColorFilter.cpp
+++ b/src/effects/SkLumaColorFilter.cpp
@@ -73,13 +73,6 @@ public:
return GrTBackendFragmentProcessorFactory<LumaColorFilterEffect>::getInstance();
}
- virtual void getConstantColorComponents(GrColor* color,
- uint32_t* validFlags) const SK_OVERRIDE {
- // The output is always black.
- *color = GrColorPackRGBA(0, 0, 0, GrColorUnpackA(*color));
- *validFlags = kRGB_GrColorComponentFlags;
- }
-
class GLProcessor : public GrGLFragmentProcessor {
public:
GLProcessor(const GrBackendProcessorFactory& factory,
@@ -119,6 +112,13 @@ private:
virtual bool onIsEqual(const GrProcessor&) const SK_OVERRIDE {
return true;
}
+
+ virtual void onComputeInvarientOutput(InvarientOutput* invarientOutput) const SK_OVERRIDE {
+ // The output is always black.
+ invarientOutput->color = GrColorPackRGBA(0, 0, 0, GrColorUnpackA(invarientOutput->color));
+ invarientOutput->validFlags = kRGB_GrColorComponentFlags;
+ invarientOutput->isSingleComponent = false;
+ }
};
GrFragmentProcessor* SkLumaColorFilter::asFragmentProcessor(GrContext*) const {

Powered by Google App Engine
This is Rietveld 408576698