Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: src/effects/SkColorFilters.cpp

Issue 608253002: Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Update comment and nits Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/effects/SkColorFilters.cpp
diff --git a/src/effects/SkColorFilters.cpp b/src/effects/SkColorFilters.cpp
index bd0d2aa6c89cfe96e5306302ac8af3b8b09da265..b6cf0937760591a4ffbf4572022b3e273c00a273 100644
--- a/src/effects/SkColorFilters.cpp
+++ b/src/effects/SkColorFilters.cpp
@@ -195,8 +195,6 @@ public:
return SkNEW_ARGS(ModeColorFilterEffect, (c, mode));
}
- virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags) const SK_OVERRIDE;
-
bool willUseFilterColor() const {
SkXfermode::Coeff dstCoeff;
SkXfermode::Coeff srcCoeff;
@@ -293,6 +291,8 @@ private:
return fMode == s.fMode && fColor == s.fColor;
}
+ virtual void onComputeInvarientOutput(InvarientOutput* invarientOutput) const SK_OVERRIDE;
+
SkXfermode::Mode fMode;
GrColor fColor;
@@ -382,18 +382,19 @@ private:
}
-void ModeColorFilterEffect::getConstantColorComponents(GrColor* color, uint32_t* validFlags) const {
+void ModeColorFilterEffect::onComputeInvarientOutput(InvarientOutput* invarientOutput) const {
float inputColor[4];
- GrColorToRGBAFloat(*color, inputColor);
+ GrColorToRGBAFloat(invarientOutput->color, inputColor);
float filterColor[4];
GrColorToRGBAFloat(fColor, filterColor);
MaskedColorExpr result =
color_filter_expression(fMode,
MaskedColorExpr(filterColor, kRGBA_GrColorComponentFlags),
- MaskedColorExpr(inputColor, *validFlags));
+ MaskedColorExpr(inputColor, invarientOutput->validFlags));
- *color = result.getColor();
- *validFlags = result.getValidComponents();
+ invarientOutput->color = result.getColor();
+ invarientOutput->validFlags = result.getValidComponents();
+ invarientOutput->isSingleComponent = false;
}
GR_DEFINE_FRAGMENT_PROCESSOR_TEST(ModeColorFilterEffect);

Powered by Google App Engine
This is Rietveld 408576698