Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: src/gpu/effects/GrRRectEffect.cpp

Issue 608253002: Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/effects/GrRRectEffect.cpp
diff --git a/src/gpu/effects/GrRRectEffect.cpp b/src/gpu/effects/GrRRectEffect.cpp
index f5131feba4bd3f7277378a2281694c9d021894d0..e5df7d27c71eea3aad79078a6489cfc6abbd8856 100644
--- a/src/gpu/effects/GrRRectEffect.cpp
+++ b/src/gpu/effects/GrRRectEffect.cpp
@@ -59,8 +59,6 @@ public:
typedef GLCircularRRectEffect GLProcessor;
- virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags) const SK_OVERRIDE;
-
virtual const GrBackendFragmentProcessorFactory& getFactory() const SK_OVERRIDE;
private:
@@ -68,6 +66,9 @@ private:
virtual bool onIsEqual(const GrProcessor& other) const SK_OVERRIDE;
+ virtual void onGetConstantColorComponents(GrColor* color, uint32_t* validFlags,
+ bool* isSingleComponent) const SK_OVERRIDE;
+
SkRRect fRRect;
GrPrimitiveEdgeType fEdgeType;
uint32_t fCircularCornerFlags;
@@ -86,7 +87,8 @@ GrFragmentProcessor* CircularRRectEffect::Create(GrPrimitiveEdgeType edgeType,
return SkNEW_ARGS(CircularRRectEffect, (edgeType, circularCornerFlags, rrect));
}
-void CircularRRectEffect::getConstantColorComponents(GrColor* color, uint32_t* validFlags) const {
+void CircularRRectEffect::onGetConstantColorComponents(GrColor* color, uint32_t* validFlags,
+ bool* isSingleComponent) const {
*validFlags = 0;
}
@@ -399,8 +401,6 @@ public:
typedef GLEllipticalRRectEffect GLProcessor;
- virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags) const SK_OVERRIDE;
-
virtual const GrBackendFragmentProcessorFactory& getFactory() const SK_OVERRIDE;
private:
@@ -408,6 +408,9 @@ private:
virtual bool onIsEqual(const GrProcessor& other) const SK_OVERRIDE;
+ virtual void onGetConstantColorComponents(GrColor* color, uint32_t* validFlags,
+ bool* isSingleComponent) const SK_OVERRIDE;
+
SkRRect fRRect;
GrPrimitiveEdgeType fEdgeType;
@@ -424,7 +427,8 @@ EllipticalRRectEffect::Create(GrPrimitiveEdgeType edgeType, const SkRRect& rrect
return SkNEW_ARGS(EllipticalRRectEffect, (edgeType, rrect));
}
-void EllipticalRRectEffect::getConstantColorComponents(GrColor* color, uint32_t* validFlags) const {
+void EllipticalRRectEffect::onGetConstantColorComponents(GrColor* color, uint32_t* validFlags,
+ bool* isSingleComponent) const {
*validFlags = 0;
}

Powered by Google App Engine
This is Rietveld 408576698