Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 608253002: Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/effects/SkLightingImageFilter.cpp
diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp
index f766562128cd6c1c65a700f6172b3fb19a1d5aac..47e1ae650b4d404f45eaa77d1f78111284ee20cf 100644
--- a/src/effects/SkLightingImageFilter.cpp
+++ b/src/effects/SkLightingImageFilter.cpp
@@ -350,15 +350,15 @@ public:
SkScalar surfaceScale() const { return fSurfaceScale; }
const SkMatrix& filterMatrix() const { return fFilterMatrix; }
- virtual void getConstantColorComponents(GrColor* color,
- uint32_t* validFlags) const SK_OVERRIDE {
+protected:
+ virtual bool onIsEqual(const GrProcessor&) const SK_OVERRIDE;
+
+ virtual void onGetConstantColorComponents(GrColor* color, uint32_t* validFlags,
+ bool* isSingleComponent) const SK_OVERRIDE {
// lighting shaders are complicated. We just throw up our hands.
*validFlags = 0;
}
-protected:
- virtual bool onIsEqual(const GrProcessor&) const SK_OVERRIDE;
-
private:
typedef GrSingleTextureEffect INHERITED;
const SkLight* fLight;

Powered by Google App Engine
This is Rietveld 408576698