Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: src/effects/SkColorFilters.cpp

Issue 608253002: Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/effects/SkColorFilters.cpp
diff --git a/src/effects/SkColorFilters.cpp b/src/effects/SkColorFilters.cpp
index bd0d2aa6c89cfe96e5306302ac8af3b8b09da265..b7fa8eb5701b7aa949a60f73048856132040ab1f 100644
--- a/src/effects/SkColorFilters.cpp
+++ b/src/effects/SkColorFilters.cpp
@@ -195,8 +195,6 @@ public:
return SkNEW_ARGS(ModeColorFilterEffect, (c, mode));
}
- virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags) const SK_OVERRIDE;
-
bool willUseFilterColor() const {
SkXfermode::Coeff dstCoeff;
SkXfermode::Coeff srcCoeff;
@@ -293,6 +291,9 @@ private:
return fMode == s.fMode && fColor == s.fColor;
}
+ virtual void onGetConstantColorComponents(GrColor* color, uint32_t* validFlags,
+ bool* isSingleComponent) const SK_OVERRIDE;
+
SkXfermode::Mode fMode;
GrColor fColor;
@@ -382,7 +383,8 @@ private:
}
-void ModeColorFilterEffect::getConstantColorComponents(GrColor* color, uint32_t* validFlags) const {
+void ModeColorFilterEffect::onGetConstantColorComponents(GrColor* color, uint32_t* validFlags,
+ bool* isSingleComponent) const {
float inputColor[4];
GrColorToRGBAFloat(*color, inputColor);
float filterColor[4];

Powered by Google App Engine
This is Rietveld 408576698