Introduced a ForwardingPolicyProvider.

chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/storage/policy_value_store.h"
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ref_counted.h"
@@ skipping 107 matching lines @@
 };
 
 TEST_F(PolicyValueStoreTest, DontProvideRecommendedPolicies) {
   policy::PolicyMap policies;
   base::FundamentalValue expected(123);
   policies.Set("must", policy::POLICY_LEVEL_MANDATORY,
                policy::POLICY_SCOPE_USER, expected.DeepCopy(), NULL);
   policies.Set("may", policy::POLICY_LEVEL_RECOMMENDED,
                policy::POLICY_SCOPE_USER,
                new base::FundamentalValue(456), NULL);
-  store_->SetCurrentPolicy(policies, false);
+  store_->SetCurrentPolicy(policies);
   ValueStore::ReadResult result = store_->Get();
   ASSERT_FALSE(result->HasError());
   EXPECT_EQ(1u, result->settings().size());
   base::Value* value = NULL;
   EXPECT_FALSE(result->settings().Get("may", &value));
   EXPECT_TRUE(result->settings().Get("must", &value));
   EXPECT_TRUE(base::Value::Equals(&expected, value));
 }
 
 TEST_F(PolicyValueStoreTest, ReadOnly) {
   ValueStore::WriteOptions options = ValueStore::DEFAULTS;
 
   base::StringValue string_value("value");
   EXPECT_TRUE(store_->Set(options, "key", string_value)->HasError());
 
   base::DictionaryValue dict;
   dict.SetString("key", "value");
   EXPECT_TRUE(store_->Set(options, dict)->HasError());
 
   EXPECT_TRUE(store_->Remove("key")->HasError());
   std::vector<std::string> keys;
   keys.push_back("key");
   EXPECT_TRUE(store_->Remove(keys)->HasError());
   EXPECT_TRUE(store_->Clear()->HasError());
 }
 
 TEST_F(PolicyValueStoreTest, NotifyOnChanges) {
+  // Notify when setting the initial policy.
+  ValueStoreChangeList changes;
+  base::StringValue value("111");
+  changes.push_back(ValueStoreChange("aaa", NULL, value.DeepCopy()));
+  EXPECT_CALL(observer_, OnSettingsChanged(kTestExtensionId,
+                                           settings_namespace::MANAGED,
+                                           ValueStoreChange::ToJson(changes)));
   policy::PolicyMap policies;
   policies.Set("aaa", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
-               new base::StringValue("111"), NULL);
-  EXPECT_CALL(observer_, OnSettingsChanged(_, _, _)).Times(0);
-  // No notification when setting the initial policy.
-  store_->SetCurrentPolicy(policies, false);
-  loop_.RunUntilIdle();
-  Mock::VerifyAndClearExpectations(&observer_);
-
-  // And no notifications on changes when not asked for.
-  policies.Set("aaa", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
-               new base::StringValue("222"), NULL);
-  policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
-               new base::StringValue("223"), NULL);
-  EXPECT_CALL(observer_, OnSettingsChanged(_, _, _)).Times(0);
-  store_->SetCurrentPolicy(policies, false);
+               value.DeepCopy(), NULL);
+  store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Notify when new policies are added.
-  ValueStoreChangeList changes;
-  base::StringValue value("333");
-  changes.push_back(ValueStoreChange("ccc", NULL, value.DeepCopy()));
-  policies.Set("ccc", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
-               value.DeepCopy(), NULL);
+  changes.clear();

[not at google - send to devlin, 2013/11/13 00:30:18]

I prefer scoping these sorts of thing explicitly using like

{
  ValueStoreChangeList changes;
  ... etc
}

{
  ValueStoreChaneList changes;
}

but I feel very weakly about it.

[Joao da Silva, 2013/11/13 08:56:47]

Done.

+  changes.push_back(ValueStoreChange("bbb", NULL, value.DeepCopy()));
   EXPECT_CALL(observer_, OnSettingsChanged(kTestExtensionId,
                                            settings_namespace::MANAGED,
                                            ValueStoreChange::ToJson(changes)));
-  store_->SetCurrentPolicy(policies, true);
+  policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
+               value.DeepCopy(), NULL);
+  store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Notify when policies change.
   changes.clear();
-  base::StringValue new_value("444");
+  base::StringValue new_value("222");
   changes.push_back(
-      ValueStoreChange("ccc", value.DeepCopy(), new_value.DeepCopy()));
-  policies.Set("ccc", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
-               new_value.DeepCopy(), NULL);
+      ValueStoreChange("bbb", value.DeepCopy(), new_value.DeepCopy()));
   EXPECT_CALL(observer_, OnSettingsChanged(kTestExtensionId,
                                            settings_namespace::MANAGED,
                                            ValueStoreChange::ToJson(changes)));
-  store_->SetCurrentPolicy(policies, true);
+  policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
+               new_value.DeepCopy(), NULL);
+  store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Notify when policies are removed.
   changes.clear();
-  changes.push_back(ValueStoreChange("ccc", new_value.DeepCopy(), NULL));
-  policies.Erase("ccc");
+  changes.push_back(ValueStoreChange("bbb", new_value.DeepCopy(), NULL));
   EXPECT_CALL(observer_, OnSettingsChanged(kTestExtensionId,
                                            settings_namespace::MANAGED,
                                            ValueStoreChange::ToJson(changes)));
-  store_->SetCurrentPolicy(policies, true);
+  policies.Erase("bbb");
+  store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
-  // Don't notify when there aren't changes.
+  // Don't notify when there aren't any changes.
   EXPECT_CALL(observer_, OnSettingsChanged(_, _, _)).Times(0);
-  store_->SetCurrentPolicy(policies, true);
+  store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 }
 
 }  // namespace extensions