Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3602)

Unified Diff: cc/animation/scrollbar_animation_controller.h

Issue 608223002: [Android]Increase Scrollbar fade delay on Resize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/animation/scrollbar_animation_controller.h
diff --git a/cc/animation/scrollbar_animation_controller.h b/cc/animation/scrollbar_animation_controller.h
index ad7f631bb9ef12877b5a7945672c1a1c44a4fcba..a245eb2e33d24e72e2af16f91db718fe32e617bf 100644
--- a/cc/animation/scrollbar_animation_controller.h
+++ b/cc/animation/scrollbar_animation_controller.h
@@ -32,7 +32,7 @@ class CC_EXPORT ScrollbarAnimationController {
void Animate(base::TimeTicks now);
virtual void DidScrollBegin();
- virtual void DidScrollUpdate();
+ virtual void DidScrollUpdate(bool on_resize = false);
aelias_OOO_until_Jul13 2014/09/30 18:55:27 Please remove this default argument.
MuVen 2014/10/01 16:45:51 Done.
virtual void DidScrollEnd();
virtual void DidMouseMoveOffScrollbar() {}
virtual void DidMouseMoveNear(float distance) {}
@@ -40,6 +40,7 @@ class CC_EXPORT ScrollbarAnimationController {
protected:
ScrollbarAnimationController(ScrollbarAnimationControllerClient* client,
base::TimeDelta delay_before_starting,
+ base::TimeDelta resize_delay_before_starting,
base::TimeDelta duration);
virtual void RunAnimationFrame(float progress) = 0;
@@ -52,11 +53,12 @@ class CC_EXPORT ScrollbarAnimationController {
// 0 to 1.
float AnimationProgressAtTime(base::TimeTicks now);
- void PostDelayedFade();
+ void PostDelayedFade(bool on_resize = false);
aelias_OOO_until_Jul13 2014/09/30 18:55:27 Please remove this default argument.
MuVen 2014/10/01 16:45:51 Done.
ScrollbarAnimationControllerClient* client_;
base::TimeTicks last_awaken_time_;
base::TimeDelta delay_before_starting_;
+ base::TimeDelta resize_delay_before_starting_;
base::TimeDelta duration_;
bool is_animating_;

Powered by Google App Engine
This is Rietveld 408576698