Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromeos/ime/component_extension_ime_manager.cc

Issue 608183002: Move all white-listed input method indicator text from InputMethodUtil to manifests of IME extensio… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revised per comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/ime/component_extension_ime_manager.h ('k') | chromeos/ime/extension_ime_util.cc » ('j') | chromeos/ime/input_method_descriptor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/ime/component_extension_ime_manager.cc
diff --git a/chromeos/ime/component_extension_ime_manager.cc b/chromeos/ime/component_extension_ime_manager.cc
index feb03477188c45b3fc18a966aacb1ae1f5d3cbba..5454a94da8f549610b7dc7db35c13d46abd4d413 100644
--- a/chromeos/ime/component_extension_ime_manager.cc
+++ b/chromeos/ime/component_extension_ime_manager.cc
@@ -154,7 +154,7 @@ input_method::InputMethodDescriptors
input_method::InputMethodDescriptor(
input_method_id,
ime.display_name,
- std::string(), // TODO(uekawa): Set short name.
+ ime.indicator,
layouts,
ime.language_codes,
// Enables extension based xkb keyboards on login screen.
« no previous file with comments | « chromeos/ime/component_extension_ime_manager.h ('k') | chromeos/ime/extension_ime_util.cc » ('j') | chromeos/ime/input_method_descriptor.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698