chrome/browser/chromeos/input_method/input_method_util_unittest.cc - Issue 608183002: Move all white-listed input method indicator text from InputMethodUtil to manifests of IME extensio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_util_unittest.cc

Issue 608183002: Move all white-listed input method indicator text from InputMethodUtil to manifests of IME extensio… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revised per comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_util.cc ('k') | chrome/browser/resources/chromeos/braille_ime/manifest.json » ('j') | chromeos/ime/input_method_descriptor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_util_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_util_unittest.cc b/chrome/browser/chromeos/input_method/input_method_util_unittest.cc

index ac3201ff936d0599497a6ab664a6e775a2992563..0f117a819635fafa6a1f269130c83fbf6fae0892 100644

--- a/chrome/browser/chromeos/input_method/input_method_util_unittest.cc

+++ b/chrome/browser/chromeos/input_method/input_method_util_unittest.cc

@@ -159,12 +159,13 @@ TEST_F(InputMethodUtilTest, GetInputMethodShortNameTest) {

}

{

InputMethodDescriptor desc =

- GetDesc(pinyin_ime_id, "us", "zh-CN", "");

+ GetDesc(pinyin_ime_id, "us", "zh-CN", "\xe6\x8b\xbc");

EXPECT_EQ(base::UTF8ToUTF16("\xe6\x8b\xbc"),

util_.GetInputMethodShortName(desc));

}

{

- InputMethodDescriptor desc = GetDesc(zhuyin_ime_id, "us", "zh-TW", "");

+ InputMethodDescriptor desc =

+ GetDesc(zhuyin_ime_id, "us", "zh-TW", "\xE6\xB3\xA8");

EXPECT_EQ(base::UTF8ToUTF16("\xE6\xB3\xA8"),

util_.GetInputMethodShortName(desc));

}