chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc - Issue 608183002: Move all white-listed input method indicator text from InputMethodUtil to manifests of IME extensio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

Issue 608183002: Move all white-listed input method indicator text from InputMethodUtil to manifests of IME extensio… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revised per comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

diff --git a/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc b/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

index 0e16247be2f2cd63e1eec2575d0db5c90c018eee..1aa41a6053b9c64e3ad87130bdc8d35a9cb551f1 100644

--- a/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

+++ b/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc

@@ -345,6 +345,8 @@ bool ComponentExtensionIMEManagerImpl::ReadEngineComponent(

return false;

if (!dict.GetString(extensions::manifest_keys::kName, &out->display_name))

return false;

+ if (!dict.GetString(extensions::manifest_keys::kIndicator, &out->indicator))

+ out->indicator = "";

// Localizes the input method name.

if (out->display_name.find("__MSG_") == 0) {

« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/input_method_util.h » ('j') | chromeos/ime/input_method_descriptor.cc » ('J')