Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 608153002: Revert of Fixed flakiness in PolicyTest.FileURLBlacklist. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixed flakiness in PolicyTest.FileURLBlacklist. (patchset #5 id:80001 of https://codereview.chromium.org/551323003/) Reason for revert: It's causing lots of flakiness on trybots, now that you added logging look at the past flakiness for more info: http://chromium-try-flakes.appspot.com/search?q=PolicyTest.FileURLBlacklist Original issue's description: > Re-enabled PolicyTest.FileURLBlacklist. > > This test flakes on the Mac. This CL adds additional logging to help diagnose the source of flakiness. > > BUG=339240 > > Committed: https://crrev.com/82405166f151d0d0be73d040aa5b77d309034aa0 > Cr-Commit-Position: refs/heads/master@{#295956} TBR=pneubeck@chromium.org,joaodasilva@chromium.org NOTREECHECKS=true NOTRY=true BUG=339240 Committed: https://crrev.com/d6be16e996debac76cdf70a85a3d4ea620b13dbb Cr-Commit-Position: refs/heads/master@{#297127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M chrome/browser/policy/policy_browsertest.cc View 9 chunks +26 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Fixed flakiness in PolicyTest.FileURLBlacklist.
6 years, 2 months ago (2014-09-28 15:17:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608153002/1
6 years, 2 months ago (2014-09-28 15:18:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 197ae2ccbbaa979bb19139dcbb9d11fb8b4e1c98
6 years, 2 months ago (2014-09-28 15:18:41 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-28 15:19:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6be16e996debac76cdf70a85a3d4ea620b13dbb
Cr-Commit-Position: refs/heads/master@{#297127}

Powered by Google App Engine
This is Rietveld 408576698