Fixes another places that may trigger deletion during tab dragging

Fixes another places that may trigger deletion during tab dragging

The call to Activate() may trigger deletion.

BUG=310746
TEST=none
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233273

[Ben Goodger (Google), 2013-11-05 20:41:31]

lgtm


On Tue, Nov 5, 2013 at 12:37 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Fixes another places that may trigger deletion during tab dragging
>
> The call to Activate() may trigger deletion.
>
> BUG=310746
> TEST=none
> R=ben@chromium.org
>
> Please review this at https://codereview.chromium.org/60813002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+3, -0 lines):
>   M chrome/browser/ui/views/tabs/tab_drag_controller.cc
>
>
> Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc
> diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc
> b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
> index bb452ef74e862ee346469916b96e9bb59ec622df..
> 15d382e1935f1342865a78d2e6545465770fd2e4 100644
> --- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc
> +++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
> @@ -1543,6 +1543,9 @@ void TabDragController::RunMoveLoop(const
> gfx::Vector2d& drag_offset) {
>        // Move the tabs into position.
>        MoveAttached(point_in_screen);
>        attached_tabstrip_->GetWidget()->Activate();
> +      // Activate may trigger a focus loss, destroying us.
> +      if (!ref)
> +        return;
>        tab_strip_to_attach_to_after_exit_ = NULL;
>      }
>      DCHECK(attached_tabstrip_);
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-11-05 21:01:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/60813002/1

[commit-bot: I haz the power, 2013-11-05 21:47:02]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-05 22:43:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/60813002/1

[commit-bot: I haz the power, 2013-11-06 02:49:21]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[sky, 2013-11-06 16:02:44]

Committed patchset #1 manually as r233273 (presubmit successful).