Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 608093002: Chromecast: adds callback for CastService to control metrics state. (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cast-network-delegate
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds callback for CastService to control metrics state. This allows CastService implementers to provide the user option for controlling whether metrics is enabled/disabled. R=lcwu@chromium.org BUG=400925 Committed: https://crrev.com/7b23fd179076904d083d9a0df047806bf31508a1 Cr-Commit-Position: refs/heads/master@{#297243}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -17 lines) Patch
M chromecast/metrics/cast_metrics_service_client.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chromecast/metrics/cast_metrics_service_client.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chromecast/service/cast_service.h View 1 2 5 chunks +13 lines, -3 lines 0 comments Download
M chromecast/service/cast_service.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chromecast/service/cast_service_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/service/cast_service_android.cc View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M chromecast/service/cast_service_simple.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/service/cast_service_simple.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M chromecast/shell/browser/cast_browser_main_parts.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
gunsch
6 years, 2 months ago (2014-09-26 23:26:51 UTC) #1
lcwu1
lgtm
6 years, 2 months ago (2014-09-29 19:33:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608093002/40001
6 years, 2 months ago (2014-09-29 19:52:31 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001) as d2dc00d59e15095fa4f9fea2108a60a68eb46049
6 years, 2 months ago (2014-09-29 20:06:23 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 20:07:10 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7b23fd179076904d083d9a0df047806bf31508a1
Cr-Commit-Position: refs/heads/master@{#297243}

Powered by Google App Engine
This is Rietveld 408576698