Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 608063002: Suppress Uninitialized access in ExtensionManagement::Refresh (Closed)

Created:
6 years, 2 months ago by oshima
Modified:
6 years, 2 months ago
Reviewers:
miu
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Suppress Uninitialized access in ExtensionManagement::Refresh BUG=418234 TBR=miu@chromium.org Committed: https://crrev.com/459b9796ff2ba105e8a6bae4c7e63508ea83bb67 Cr-Commit-Position: refs/heads/master@{#297028}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
6 years, 2 months ago (2014-09-26 20:56:14 UTC) #1
oshima
Committed patchset #2 (id:20001) manually as 459b979 (presubmit successful).
6 years, 2 months ago (2014-09-26 20:57:46 UTC) #2
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/459b9796ff2ba105e8a6bae4c7e63508ea83bb67 Cr-Commit-Position: refs/heads/master@{#297028}
6 years, 2 months ago (2014-09-26 20:57:47 UTC) #3
miu
lgtm
6 years, 2 months ago (2014-09-26 20:59:50 UTC) #4
hans
6 years, 2 months ago (2014-09-26 23:48:25 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/610753002/ by hans@chromium.org.

The reason for reverting is: The Clang roll that caused the Valgrind error was
reverted in
https://chromium.googlesource.com/chromium/src/+/3c80ac9fd48da3d11852eecd6999....

Powered by Google App Engine
This is Rietveld 408576698