Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 60803002: Simpler bindings, fewer files! (Closed)

Created:
7 years, 1 month ago by darin (slow to review)
Modified:
7 years, 1 month ago
Reviewers:
DaveMoore
CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : move more to the .cc file #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -620 lines) Patch
M mojo/mojo.gyp View 1 chunk +2 lines, -12 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_bar.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_bar.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_bar_serialization.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_bar_serialization.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_foo.h View 1 chunk +0 lines, -81 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_foo.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_foo_serialization.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_foo_serialization.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M mojo/public/bindings/sample/generated/sample_service.h View 1 chunk +113 lines, -1 line 1 comment Download
A mojo/public/bindings/sample/generated/sample_service.cc View 1 1 chunk +266 lines, -0 lines 0 comments Download
A + mojo/public/bindings/sample/generated/sample_service_internal.h View 1 2 chunks +17 lines, -7 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_service_proxy.h View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_service_proxy.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_service_serialization.h View 1 chunk +0 lines, -73 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_service_serialization.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_service_stub.h View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/public/bindings/sample/generated/sample_service_stub.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M mojo/public/bindings/sample/sample_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
darin (slow to review)
7 years, 1 month ago (2013-11-05 20:31:54 UTC) #1
DaveMoore
https://codereview.chromium.org/60803002/diff/40001/mojo/public/bindings/sample/generated/sample_service.h File mojo/public/bindings/sample/generated/sample_service.h (right): https://codereview.chromium.org/60803002/diff/40001/mojo/public/bindings/sample/generated/sample_service.h#newcode9 mojo/public/bindings/sample/generated/sample_service.h:9: #include "mojo/public/bindings/lib/message.h" Where would the name "sample_service" come from? ...
7 years, 1 month ago (2013-11-06 15:54:01 UTC) #2
darin (slow to review)
The name of the generated files is derived from the name of the IDL file. ...
7 years, 1 month ago (2013-11-06 16:43:00 UTC) #3
DaveMoore
lgtm
7 years, 1 month ago (2013-11-06 17:17:33 UTC) #4
darin (slow to review)
7 years, 1 month ago (2013-11-06 17:31:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r233283 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698