Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Issue 608023002: Some fixes for gn examples (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Some fixes for gn examples Fixes up various dependency bugs that prevent mojo_demo_launcher + mojo_html_viewer from working. Once we are gn check clean this should be easy to enforce with a script, but for now it's manual testing. R=abarth@chromium.org Committed: https://crrev.com/f8831db369da6c5c334a0defae6f22358760cce2 Cr-Commit-Position: refs/heads/master@{#297023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M mojo/examples/demo_launcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/html_viewer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/network/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jamesr
6 years, 2 months ago (2014-09-26 19:57:54 UTC) #1
abarth-chromium
lgtm
6 years, 2 months ago (2014-09-26 19:59:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608023002/1
6 years, 2 months ago (2014-09-26 20:02:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 472ca80c5830a67922b2dba9e82f96615c0c8e3c
6 years, 2 months ago (2014-09-26 20:34:34 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 20:35:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8831db369da6c5c334a0defae6f22358760cce2
Cr-Commit-Position: refs/heads/master@{#297023}

Powered by Google App Engine
This is Rietveld 408576698