Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 608013004: Remove VPX conditionals from media and remoting. (Closed)

Created:
6 years, 2 months ago by brettw
Modified:
6 years, 2 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, chromoting-reviews_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove VPX conditionals from media and remoting. We added some #ifdefs in https://codereview.chromium.org/501153003 to support compiling these components with no libvpx to get the GN build linking. Now that chrome links in GN with libvpx, we can remove these since this isn't a configuration we want to support. Committed: https://crrev.com/bbe9ed1510413458943b3b39e1e9dad3965e5d32 Cr-Commit-Position: refs/heads/master@{#297083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M media/cast/sender/video_encoder_impl.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M remoting/client/software_video_renderer.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M remoting/protocol/session_config.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
6 years, 2 months ago (2014-09-26 21:31:22 UTC) #2
Alpha Left Google
media/cast LGTM.
6 years, 2 months ago (2014-09-26 21:32:23 UTC) #4
Sergey Ulanov
LGTM, thanks!
6 years, 2 months ago (2014-09-26 22:54:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608013004/1
6 years, 2 months ago (2014-09-27 00:27:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 68ca86d2bd9838486a6903a3f6106c8743c904ff
6 years, 2 months ago (2014-09-27 00:32:42 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 00:33:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbe9ed1510413458943b3b39e1e9dad3965e5d32
Cr-Commit-Position: refs/heads/master@{#297083}

Powered by Google App Engine
This is Rietveld 408576698