Fix regression where extension action icons may not be displayed properly

Fix regression where extension action icons may not be displayed properly

A BrowserActionView can set its image view for the first time in UpdateState(),
but UpdateState() only called SchedulePaint(), and not Layout() (which is
necessary for the image). Coincidentally, with all the Layout()s called on
BrowserActionsContainer, this only manifested itself in Windows 8 Metro Mode
(likely because race conditions caused the image to be updated after all calls
to Layout()).

BUG=409782
Committed: https://crrev.com/e458b1081aaa5e60d5e32ed93d882ed9b65126d2
Cr-Commit-Position: refs/heads/master@{#297069}

[Devlin, 2014-09-26 19:36:09]

rdevlin.cronin@chromium.org changed reviewers:
+ pkasting@chromium.org

[Devlin, 2014-09-26 19:36:09]

Peter, mind taking a quick look?

[Peter Kasting, 2014-09-26 20:28:18]

https://codereview.chromium.org/608013002/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/browser_action_view.cc (right):

https://codereview.chromium.org/608013002/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/browser_action_view.cc:82: Layout();  // We need
to layout since we may have added an icon as a result.
Should Layout() call UpdateState()?  Conversely, should UpdateState() call
Layout()?

[Devlin, 2014-09-26 20:45:34]

https://codereview.chromium.org/608013002/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/browser_action_view.cc (right):

https://codereview.chromium.org/608013002/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/browser_action_view.cc:82: Layout();  // We need
to layout since we may have added an icon as a result.
On 2014/09/26 20:28:17, Peter Kasting wrote:
> Should Layout() call UpdateState()?  Conversely, should UpdateState() call
> Layout()?

Sorry about that - copied the patch over from a Win8 testing machine, and
somewhere along the line it made it into the wrong method.  This was supposed to
be in UpdateState(), which is where the image is set.  We shouldn't have to
worry about calling UpdateState() from Layout() (since we only update state when
something has changed, and UpdateState() now calls Layout()).

[Peter Kasting, 2014-09-26 20:46:25]

LGTM

[Devlin, 2014-09-26 20:47:23]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-09-26 20:48:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/608013002/20001

[commit-bot: I haz the power, 2014-09-26 23:30:57]

Committed patchset #2 (id:20001) as f4a2edc4372e9c72713277b96a701724c25937da

[commit-bot: I haz the power, 2014-09-26 23:31:37]

Patchset 2 (id:??) landed as
https://crrev.com/e458b1081aaa5e60d5e32ed93d882ed9b65126d2
Cr-Commit-Position: refs/heads/master@{#297069}