Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 607973003: It's weird that two who really owns the usrsctp code in Chromium are not in (Closed)

Created:
6 years, 2 months ago by Mallinath (Gone from Chromium)
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

It's weird that two who really owns the usrsctp code in Chromium are not in owners file. Ronghua, let me know if you want to be in OWNERS file. R=ronghuawu@chromium.org,lally@chromium.org,ldixon@chromium.org Committed: https://crrev.com/1cbaf3d0e783d0a97cf31f3cbd3cc204dab157d0 Cr-Commit-Position: refs/heads/master@{#297064}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/usrsctp/OWNERS View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Mallinath (Gone from Chromium)
6 years, 2 months ago (2014-09-26 20:50:11 UTC) #1
lally
lgtm Lucas is out this week. This'd make life easier, especially with the various fixes ...
6 years, 2 months ago (2014-09-26 21:01:28 UTC) #2
chromium-reviews
I always thought you and Lucas are in owners file, never realized that's not the ...
6 years, 2 months ago (2014-09-26 21:08:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607973003/1
6 years, 2 months ago (2014-09-26 22:27:00 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-09-26 22:27:03 UTC) #7
Mallinath (Gone from Chromium)
Adding JIayang, as she is full super star committer!. Jiayng, I need your lgtm to ...
6 years, 2 months ago (2014-09-26 22:34:13 UTC) #9
jiayl
lgtm
6 years, 2 months ago (2014-09-26 22:38:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607973003/20001
6 years, 2 months ago (2014-09-26 22:44:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 107b0d1acd299f1430f5e5d004817a282fc62684
6 years, 2 months ago (2014-09-26 23:20:09 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 23:20:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1cbaf3d0e783d0a97cf31f3cbd3cc204dab157d0
Cr-Commit-Position: refs/heads/master@{#297064}

Powered by Google App Engine
This is Rietveld 408576698