Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 607953004: Importer - Add defensive check for data from IPC (Closed)

Created:
6 years, 2 months ago by Nikhil
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Importer - Add defensive check for data from IPC This patch updates the '==' condition to '>=' as a defensive check against data coming from IPC message. BUG=418942 Committed: https://crrev.com/f58ffed3ac10c0d081e2dc6fcb523d3098fcd183 Cr-Commit-Position: refs/heads/master@{#297601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/importer/external_process_importer_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Nikhil
isherman@ - This is last of the follow-up CLs series. Please take a look :) ...
6 years, 2 months ago (2014-09-30 12:55:04 UTC) #2
Nikhil
On 2014/09/30 12:55:04, Nikhil wrote: > isherman@ - This is last of the follow-up CLs ...
6 years, 2 months ago (2014-09-30 12:57:31 UTC) #3
Ilya Sherman
Thanks, Nikhil. LGTM. By the way, now that you're a committer, you should have permissions ...
6 years, 2 months ago (2014-09-30 20:18:08 UTC) #4
Nikhil
On 2014/09/30 20:18:08, Ilya Sherman wrote: > Thanks, Nikhil. LGTM. > > By the way, ...
6 years, 2 months ago (2014-10-01 06:02:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607953004/1
6 years, 2 months ago (2014-10-01 06:03:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2959c86249c2af7b7a80e41072f35b721f26e8f9
6 years, 2 months ago (2014-10-01 06:49:23 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 06:50:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f58ffed3ac10c0d081e2dc6fcb523d3098fcd183
Cr-Commit-Position: refs/heads/master@{#297601}

Powered by Google App Engine
This is Rietveld 408576698