mojo: Fix java generator

mojo: Fix java generator

Fix issue with method with empty response.
Fix issue with local variable shadowing user parameters.

R=ppi@chromium.org

Committed: https://crrev.com/9f187aa3de7e2f5b7ab759594e7b3c4e3c4083de
Cr-Commit-Position: refs/heads/master@{#297176}

[ppi, 2014-09-26 19:09:35]

Thanks! I think we're still missing at least one bit - with the patch I get the
following when building the "mojo_test_app" target:

/tmp/tmpliBHdv/java/org/chromium/mojom/mojo/test/TestTimeService_Internal.java:92:
error: method startTrackingRequests in interface TestTimeService cannot be
applied to given types;
                        getImpl().startTrackingRequests();
                                 ^
  required: StartTrackingRequestsResponse
  found: no arguments
  reason: actual and formal argument lists differ in length
/tmp/tmpliBHdv/java/org/chromium/mojom/mojo/test/TestService_Internal.java:107:
error: method ping in interface TestService cannot be applied to given types;
                        getImpl().ping();
                                 ^
  required: PingResponse
  found: no arguments
  reason: actual and formal argument lists differ in length
/tmp/tmpliBHdv/java/org/chromium/mojom/mojo/test/TestService_Internal.java:112:
error: method startTrackingRequests in interface TestService cannot be applied
to given types;
                        getImpl().startTrackingRequests();

[qsr, 2014-09-29 08:00:23]

Fixed. Also, added a non regression mojom file to ensure we won't regress on
those 2 issues.

[ppi, 2014-09-29 08:33:27]

Thanks! Some more errors with the current patch:

ninja -j2000 -C out_gn/Debug media/mojo/interfaces:interfaces_java

/tmp/tmpmQZQfG/java/org/chromium/mojom/mojo/ChannelLayout.java:46: error: cannot
find symbol
    public static final int k_MAX = (int)
(ChannelLayout.STEREO_AND_KEYBOARD_MIC);
                                                        ^
  symbol:   variable STEREO_AND_KEYBOARD_MIC
  location: class ChannelLayout
/tmp/tmpmQZQfG/java/org/chromium/mojom/mojo/ChannelLayout.java:46: error:
illegal start of type
    public static final int k_MAX = (int)
(ChannelLayout.STEREO_AND_KEYBOARD_MIC);
                                          ^
/tmp/tmpmQZQfG/java/org/chromium/mojom/mojo/MediaRenderer_Internal.java:131:
error: method initialize in interface MediaRenderer cannot be applied to given
types;
                        getImpl().initialize(data.stream);
                                 ^
  required: DemuxerStream,InitializeResponse
  found: DemuxerStream
  reason: actual and formal argument lists differ in length
/tmp/tmpmQZQfG/java/org/chromium/mojom/mojo/MediaRenderer_Internal.java:136:
error: method flush in interface MediaRenderer cannot be applied to given types;
                        getImpl().flush();
                                 ^
  required: FlushResponse
  found: no arguments
  reason: actual and formal argument lists differ in length
/tmp/tmpmQZQfG/java/org/chromium/mojom/mojo/SampleFormat.java:22: error: cannot
find symbol
    public static final int Max = (int) (SampleFormat.PLANAR_F32);
                                                     ^
  symbol:   variable PLANAR_F32
  location: class SampleFormat
/tmp/tmpmQZQfG/java/org/chromium/mojom/mojo/SampleFormat.java:22: error: illegal
start of type
    public static final int Max = (int) (SampleFormat.PLANAR_F32);

################################################################

ninja -j2000 -C out_gn/Debug
mojo/services/public/interfaces/native_viewport:native_viewport_java

/tmp/tmpm8CHVK/java/org/chromium/mojom/mojo/NativeViewport.java:20: error:
cannot find symbol
    void create(Size size);
                ^
  symbol:   class Size
  location: interface NativeViewport
/tmp/tmpm8CHVK/java/org/chromium/mojom/mojo/NativeViewport.java:28: error:
cannot find symbol
    void setBounds(Size size);
                   ^
  symbol:   class Size
  location: interface NativeViewport
/tmp/tmpm8CHVK/java/org/chromium/mojom/mojo/NativeViewport.java:30: error:
cannot find symbol
    void submittedFrame(SurfaceId surfaceId);
                        ^
  symbol:   class SurfaceId
  location: interface NativeViewport
/tmp/tmpm8CHVK/java/org/chromium/mojom/mojo/NativeViewportClient.java:22: error:
cannot find symbol
    void onBoundsChanged(Size size);
                         ^
  symbol:   class Size   
  location: interface NativeViewportClient
/tmp/tmpm8CHVK/java/org/chromium/mojom/mojo/NativeViewportClient.java:26: error:
cannot find symbol
    void onEvent(Event event, OnEventResponse callback);
                 ^
  symbol:   class Event
  location: interface NativeViewportClient
/tmp/tmpm8CHVK/java/org/chromium/mojom/mojo/NativeViewport_Internal.java:55:
error: cannot find symbol
        public void create(Size size) {

https://codereview.chromium.org/607933002/diff/20001/mojo/public/interfaces/b...
File mojo/public/interfaces/bindings/tests/non_regression.mojom (right):

https://codereview.chromium.org/607933002/diff/20001/mojo/public/interfaces/b...
mojo/public/interfaces/bindings/tests/non_regression.mojom:5: // Module
containing entity to ensure non regression of the generator. Entities
nit: I think these are traditionally called "regression tests" (meaning "tests
ensuring no regressions"). I'd suggest to start the comment like "Module
containing entities for regression tests of the generator. (...)" and naming the
file just "regression.mojom" or "regression_tests.mojom". Wdyt?

[ppi, 2014-09-29 08:38:36]

One more, although this could as well be a problem with the build file:

ninja -j2000 -C out_gn/Debug content/common:mojo_bindings_java

/tmp/tmpWnkVGs/java/org/chromium/mojom/content/RenderFrameSetup.java:20: error:
package org.chromium.mojom.mojo does not exist
    void getServiceProviderForFrame(int frameRoutingId,
org.chromium.mojo.bindings.InterfaceRequest<org.chromium.mojom.mojo.ServiceProvider>
serviceProvider);
                                                                                
                                          ^
/tmp/tmpWnkVGs/java/org/chromium/mojom/content/RenderFrameSetup_Internal.java:46:
error: package org.chromium.mojom.mojo does not exist
        public void getServiceProviderForFrame(int frameRoutingId,
org.chromium.mojo.bindings.InterfaceRequest<org.chromium.mojom.mojo.ServiceProvider>
serviceProvider) {
                                                                                
                                                     ^
/tmp/tmpWnkVGs/java/org/chromium/mojom/content/RenderFrameSetup_Internal.java:100:
error: package org.chromium.mojom.mojo does not exist
        public
org.chromium.mojo.bindings.InterfaceRequest<org.chromium.mojom.mojo.ServiceProvider>
serviceProvider;

[qsr, 2014-09-29 08:41:37]

On 2014/09/29 08:38:36, ppi wrote:
> One more, although this could as well be a problem with the build file:
> 
> ninja -j2000 -C out_gn/Debug content/common:mojo_bindings_java
> 
> /tmp/tmpWnkVGs/java/org/chromium/mojom/content/RenderFrameSetup.java:20:
error:
> package org.chromium.mojom.mojo does not exist
>     void getServiceProviderForFrame(int frameRoutingId,
>
org.chromium.mojo.bindings.InterfaceRequest<org.chromium.mojom.mojo.ServiceProvider>
> serviceProvider);
>                                                                               
 
>                                           ^
>
/tmp/tmpWnkVGs/java/org/chromium/mojom/content/RenderFrameSetup_Internal.java:46:
> error: package org.chromium.mojom.mojo does not exist
>         public void getServiceProviderForFrame(int frameRoutingId,
>
org.chromium.mojo.bindings.InterfaceRequest<org.chromium.mojom.mojo.ServiceProvider>
> serviceProvider) {
>                                                                               
 
>                                                      ^
>
/tmp/tmpWnkVGs/java/org/chromium/mojom/content/RenderFrameSetup_Internal.java:100:
> error: package org.chromium.mojom.mojo does not exist
>         public
>
org.chromium.mojo.bindings.InterfaceRequest<org.chromium.mojom.mojo.ServiceProvider>
> serviceProvider;

 You are missing a dependency to the bindings code. You should ensure that in
the BUILD.gn by adding it in your android_library.

[ppi, 2014-09-29 11:51:39]

lgtm

[qsr, 2014-09-29 12:14:15]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-09-29 12:15:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607933002/70001

[commit-bot: I haz the power, 2014-09-29 13:00:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 13:00:04]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[qsr, 2014-09-29 13:23:03]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-09-29 13:23:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607933002/90001

[commit-bot: I haz the power, 2014-09-29 14:40:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 14:40:30]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[qsr, 2014-09-29 14:58:15]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-09-29 14:59:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607933002/90001

[commit-bot: I haz the power, 2014-09-29 15:24:39]

Committed patchset #6 (id:90001) as c34f088977e205ad4fa7043110b0bad651077578

[commit-bot: I haz the power, 2014-09-29 15:25:31]

Patchset 6 (id:??) landed as
https://crrev.com/9f187aa3de7e2f5b7ab759594e7b3c4e3c4083de
Cr-Commit-Position: refs/heads/master@{#297176}