Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 60793002: MIPS: Avoid using dd() in Prologue when --optimize-for-size. (Closed)

Created:
7 years, 1 month ago by kilvadyb
Modified:
7 years, 1 month ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Avoid using dd() in Prologue when --optimize-for-size. Port: r17485 (0d82025) Original commit message: When --optimize-for-size is true, the prologue generation outputs the pre-aging code stub address directly to the instruction stream. Previously this was done using dd() which failed if there was any pending constant pool entries left to be written. This CL introduces an emit_code_stub_address() for this purpose instead. BUG=v8:2968

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 1 month ago (2013-11-05 20:33:39 UTC) #1
Paul Lind
The mips version of dd() did not have the constant pool issue, but it's worth ...
7 years, 1 month ago (2013-11-05 20:42:09 UTC) #2
Paul Lind
7 years, 1 month ago (2013-11-05 20:49:35 UTC) #3
Committed as r17508.

Powered by Google App Engine
This is Rietveld 408576698