Issue 607923002: [NaCl SDK] Fix url_loader example for MSVC 2013

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 607923002: [NaCl SDK] Fix url_loader example for MSVC 2013 (Closed)

Created:
6 years, 2 months ago by binji

Modified:
6 years, 2 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Fix url_loader example for MSVC 2013 This is the same issue as in 8d01729a29f. MSVC 2013 now requires including <algorithm> to use std::{min, max}. BUG=none R=sbc@chromium.org

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	native_client_sdk/src/examples/api/url_loader/url_loader_handler.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/37755be4c606743895c0c24d5b2ea4c25af6859d Cr-Commit-Position: refs/heads/master@{#296984}

6 years, 2 months ago (2014-09-26 18:33:26 UTC) #3

binji

6 years, 2 months ago (2014-09-26 18:33:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as 72dd066 (presubmit
successful).

Expand Messages | Collapse Messages