Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 607913005: Moving more tests to app_shell_browsertests. (Closed)

Created:
6 years, 2 months ago by lfg
Modified:
6 years, 2 months ago
Reviewers:
Fady Samuel, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Xi Han, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moving more tests to app_shell_browsertests. This CL adds the following tests to app_shell_browsertests: WebViewAPITest.testAssignSrcAfterCrash WebViewAPITest.testCannotMutateEventName WebViewAPITest.testContentLoadEvent WebViewAPITest.tDestroyOnEventListener WebViewAPITest.testDisplayNoneWebviewLoad WebViewAPITest.testDisplayNoneWebviewRemoveChild WebViewAPITest.testExecuteScript WebViewAPITest.testExecuteScriptFail BUG=352293 Committed: https://crrev.com/9ffe59798e0d724b3e996bbd07bc3376ea130d58 Cr-Commit-Position: refs/heads/master@{#297256}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -1 line) Patch
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 2 chunks +34 lines, -0 lines 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 2 chunks +211 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
lfg
6 years, 2 months ago (2014-09-26 22:09:37 UTC) #2
Fady Samuel
lgtm
6 years, 2 months ago (2014-09-29 12:13:50 UTC) #3
lfg
6 years, 2 months ago (2014-09-29 17:58:18 UTC) #5
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-09-29 20:54:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607913005/20001
6 years, 2 months ago (2014-09-29 20:57:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b5323f1753b94d073d7083165f213ed97cbeca2f
6 years, 2 months ago (2014-09-29 21:02:41 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:05:28 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ffe59798e0d724b3e996bbd07bc3376ea130d58
Cr-Commit-Position: refs/heads/master@{#297256}

Powered by Google App Engine
This is Rietveld 408576698