Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 607913004: Revert of DevTools: Protocol handler generator for content (Closed)

Created:
6 years, 2 months ago by Zhenyao Mo
Modified:
6 years, 2 months ago
CC:
aandrey+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, paulirish+reviews_chromium.org, vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Protocol handler generator for content (patchset #30 id:580001 of https://codereview.chromium.org/508973003/) Reason for revert: This causes a lot of layout tests to timeout on Linux ASAN bot in webkit waterfall. Original issue's description: > DevTools: Protocol handler generator for content > > BUG=405566 > > Committed: https://crrev.com/4b0b62979ddd96b65064364eb669ec9dda7e5e5e > Cr-Commit-Position: refs/heads/master@{#296723} TBR=jochen@chromium.org,dgozman@chromium.org,pfeldman@chromium.org,yurys@chromium.org,vkuzkokov@chromium.org NOTREECHECKS=true NOTRY=true BUG=405566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -1842 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 2 chunks +0 lines, -25 lines 0 comments Download
D content/browser/devtools/devtools.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
D content/browser/devtools/protocol/devtools_protocol_client.h View 1 chunk +0 lines, -76 lines 0 comments Download
D content/browser/devtools/protocol/devtools_protocol_client.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +0 lines, -777 lines 0 comments Download
D content/browser/devtools/protocol/dom_handler.h View 1 chunk +0 lines, -32 lines 0 comments Download
D content/browser/devtools/protocol/dom_handler.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D content/browser/devtools/protocol/input_handler.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/browser/devtools/protocol/input_handler.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D content/browser/devtools/protocol/inspector_handler.h View 1 chunk +0 lines, -31 lines 0 comments Download
D content/browser/devtools/protocol/inspector_handler.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D content/browser/devtools/protocol/network_handler.h View 1 chunk +0 lines, -38 lines 0 comments Download
D content/browser/devtools/protocol/network_handler.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D content/browser/devtools/protocol/page_handler.h View 1 chunk +0 lines, -80 lines 0 comments Download
D content/browser/devtools/protocol/page_handler.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D content/browser/devtools/protocol/power_handler.h View 1 chunk +0 lines, -38 lines 0 comments Download
D content/browser/devtools/protocol/power_handler.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D content/browser/devtools/protocol/tracing_handler.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/devtools/protocol/tracing_handler.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D content/browser/devtools/protocol/worker_handler.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/browser/devtools/protocol/worker_handler.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 5 chunks +0 lines, -13 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler.h View 3 chunks +11 lines, -0 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler.cc View 4 chunks +175 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Zhenyao Mo
6 years, 2 months ago (2014-09-26 21:14:35 UTC) #1 
Created Revert of DevTools: Protocol handler generator for content

Powered by Google App Engine
This is Rietveld 408576698