Issue 607913003: Improved error reporting in cryptotoken

Issue 607913003: Improved error reporting in cryptotoken (Closed)

Created:
6 years, 2 months ago by Arnar Birgisson

Modified:
6 years, 2 months ago

Reviewers:
xiyuan, juanlang (chromium.org)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Improved error reporting in cryptotoken BUG=416998 Committed: https://crrev.com/72a0d08b12b6876b7974d8cdb5eb1c85c4c9bb0c Cr-Commit-Position: refs/heads/master@{#297036}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -88 lines)			Patch
M	chrome/browser/resources/cryptotoken/enroller.js	View	11 chunks	+74 lines, -49 lines	0 comments	Download
M	chrome/browser/resources/cryptotoken/errorcodes.js	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/resources/cryptotoken/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/cryptotoken/signer.js	View	15 chunks	+40 lines, -27 lines	0 comments	Download
M	chrome/browser/resources/cryptotoken/webrequest.js	View	1 chunk	+13 lines, -10 lines	0 comments	Download

Total messages: 8 (2 generated)

Arnar Birgisson

Hi Xiyuan, Here's one more change we'd like to get into 39 if possible. cheers, ...

6 years, 2 months ago (2014-09-26 19:55:28 UTC) #2

juanlang (chromium.org)

On 2014/09/26 19:58:27, xiyuan wrote: > LGTM but please let Juan take a look as ...

6 years, 2 months ago (2014-09-26 20:18:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607913003/1

6 years, 2 months ago (2014-09-26 20:27:45 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as 2658ad3238889221c9178aa773c61019cb3698b9

6 years, 2 months ago (2014-09-26 21:20:56 UTC) #7

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 21:21:37 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/72a0d08b12b6876b7974d8cdb5eb1c85c4c9bb0c
Cr-Commit-Position: refs/heads/master@{#297036}