Report promise reject with no handler (behind a flag).

Report promise reject with no handler (behind a flag).

Main changes include:
- refactorings of exception handling in isolate.cc.
- explicit marking of whether a reject handler exists/existed.
- explicit marking of already reported promises.
- test cases

R=aandrey@chromium.org, rossberg@chromium.org, yurys@chromium.org
BUG=v8:3093
API=v8::Message::GetPromise(), v8::Promise::HasRejectHandler()
LOG=Y

[Yang, 2014-09-26 13:46:50]

On 2014/09/26 13:40:39, Yang wrote:

The reason I'm putting this behind a flag is because this may break test
expectations in blink regarding reported messages. Now promise rejects can also
trigger messages.

[aandrey, 2014-09-26 14:58:46]

looks good

https://codereview.chromium.org/607913002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/607913002/diff/1/src/api.cc#newcode5988
src/api.cc:5988: LOG_API(isolate, "Promise::Then");
Promise::Then ?

https://codereview.chromium.org/607913002/diff/1/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/607913002/diff/1/src/debug.cc#newcode2521
src/debug.cc:2521: if (promise->IsJSObject()) {
can it be "if (!uncaught && promise->IsJSObject())" ?
or Execution::PromiseHasRejectHandler() has side effects (marking a promise
reported)?

https://codereview.chromium.org/607913002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/607913002/diff/1/src/objects.h#newcode7658
src/objects.h:7658: // [arguments]: the arguments for formatting the error
message.
copy pasted

[Yang, 2014-09-26 15:04:42]

https://codereview.chromium.org/607913002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/607913002/diff/1/src/api.cc#newcode5988
src/api.cc:5988: LOG_API(isolate, "Promise::Then");
On 2014/09/26 14:58:46, aandrey wrote:
> Promise::Then ?

Done. Obviously a copy/paste mistake.

https://codereview.chromium.org/607913002/diff/1/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/607913002/diff/1/src/debug.cc#newcode2521
src/debug.cc:2521: if (promise->IsJSObject()) {
On 2014/09/26 14:58:46, aandrey wrote:
> can it be "if (!uncaught && promise->IsJSObject())" ?
> or Execution::PromiseHasRejectHandler() has side effects (marking a promise
> reported)?

Done.

I agree. The side effect is now gone. We mark the promise as reported in
Isolate::DoThrow.

https://codereview.chromium.org/607913002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/607913002/diff/1/src/objects.h#newcode7658
src/objects.h:7658: // [arguments]: the arguments for formatting the error
message.
On 2014/09/26 14:58:46, aandrey wrote:
> copy pasted

Done.

[aandrey, 2014-09-26 15:08:53]

https://codereview.chromium.org/607913002/diff/20001/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/607913002/diff/20001/src/debug.cc#newcode2526
src/debug.cc:2526: uncaught |= has_reject_handler->IsFalse();
uncaught =

[Yang, 2014-09-26 15:10:21]

https://codereview.chromium.org/607913002/diff/20001/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/607913002/diff/20001/src/debug.cc#newcode2526
src/debug.cc:2526: uncaught |= has_reject_handler->IsFalse();
On 2014/09/26 15:08:52, aandrey wrote:
> uncaught =

Done.

[Yang, 2014-09-29 13:43:24]

On 2014/09/26 15:10:21, Yang wrote:
> https://codereview.chromium.org/607913002/diff/20001/src/debug.cc
> File src/debug.cc (right):
> 
> https://codereview.chromium.org/607913002/diff/20001/src/debug.cc#newcode2526
> src/debug.cc:2526: uncaught |= has_reject_handler->IsFalse();
> On 2014/09/26 15:08:52, aandrey wrote:
> > uncaught =
> 
> Done.

Closing this as I'll work on an alternative.

[Yang, 2014-09-29 14:54:43]

On 2014/09/29 13:43:24, Yang wrote:
> On 2014/09/26 15:10:21, Yang wrote:
> > https://codereview.chromium.org/607913002/diff/20001/src/debug.cc
> > File src/debug.cc (right):
> > 
> >
https://codereview.chromium.org/607913002/diff/20001/src/debug.cc#newcode2526
> > src/debug.cc:2526: uncaught |= has_reject_handler->IsFalse();
> > On 2014/09/26 15:08:52, aandrey wrote:
> > > uncaught =
> > 
> > Done.
> 
> Closing this as I'll work on an alternative.

the successor to this is https://codereview.chromium.org/600723005/.