Issue 19141. Update 'pause on exception' in all live isolates on preference change.

Issue 19141. Update 'pause on exception' in all live isolates on preference change.

R=devoncarew@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19141

Committed: https://code.google.com/p/dart/source/detail?r=40746

[devoncarew, 2014-09-27 16:27:33]

lgtm

Looks good. One suggestion: ServerDebugTarget listens for the pref change,
ServerBreakpointManager does the work of changing the isolates.

https://codereview.chromium.org/607893008/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugTarget.java
(right):

https://codereview.chromium.org/607893008/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugTarget.java:79:
private final List<VmIsolate> liveIsolates = Lists.newArrayList();
The ServerBreakpointManager class already maintains a list of live isolates.
Perhaps, have this class listen for the preference change, but ask the
ServerBreakpointManager to set the break on exceptions setting for each isolate?
ServerBreakpointManager.setBreakOnExceptions(...).

[scheglov, 2014-09-27 18:34:05]

https://codereview.chromium.org/607893008/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugTarget.java
(right):

https://codereview.chromium.org/607893008/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerDebugTarget.java:79:
private final List<VmIsolate> liveIsolates = Lists.newArrayList();
On 2014/09/27 16:27:33, devoncarew wrote:
> The ServerBreakpointManager class already maintains a list of live isolates.
> Perhaps, have this class listen for the preference change, but ask the
> ServerBreakpointManager to set the break on exceptions setting for each
isolate?
> ServerBreakpointManager.setBreakOnExceptions(...).

Done.

[scheglov, 2014-09-27 18:34:22]

Committed patchset #2 (id:20001) manually as 40746 (presubmit successful).