Add tag write access to merge script.

tools/push-to-trunk/common_includes.py

 #!/usr/bin/env python
 # Copyright 2013 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
@@ skipping 278 matching lines @@
   def Land(self):
     raise NotImplementedError()
 
   def CLLand(self):
     raise NotImplementedError()
 
   # TODO(machenbach): There is some svn knowledge in this interface. In svn,
   # tag and commit are different remote commands, while in git we would commit
   # and tag locally and then push/land in one unique step.
   def Tag(self, tag):
+    """Sets a tag for the current commit.
+
+    Assumptions: The commit already landed and the commit message is unique.
+    """
     raise NotImplementedError()
 
 
 class GitSvnInterface(VCInterface):
   def Pull(self):
     self.step.GitSVNRebase()
 
   def Fetch(self):
     self.step.GitSVNFetch()
 
@@ skipping 30 matching lines @@
   def Land(self):
     self.step.GitSVNDCommit()
 
   def CLLand(self):
     self.step.GitDCommit()
 
   def Tag(self, tag):
     self.step.GitSVNTag(tag)
 
 
-class GitReadOnlyMixin(VCInterface):
+class GitTagsOnlyMixin(VCInterface):
   def Pull(self):
     self.step.GitPull()
 
   def Fetch(self):
     self.step.Git("fetch")
 
   def GetTags(self):
      return self.step.Git("tag").strip().splitlines()
 
   def GetBranches(self):
     # Get relevant remote branches, e.g. "origin/branch-heads/3.25".
     branches = filter(
         lambda s: re.match(r"^origin/branch\-heads/\d+\.\d+$", s),
         self.step.GitRemotes())
     # Remove 'origin/branch-heads/' prefix.
     return map(lambda s: s[20:], branches)
 
   def RemoteMasterBranch(self):
     return "origin/master"
 
   def RemoteCandidateBranch(self):
     return "origin/candidates"
 
   def RemoteBranch(self, name):
     if name in ["candidates", "master"]:
       return "origin/%s" % name
     return "origin/branch-heads/%s" % name
 
+  def Tag(self, tag):
+    # Title of the current commit (the local title and the title for committing
+    # is the same in all merge and push scripts).
+    title = self.step.GitLog(n=1, format="%s")
 
-class GitReadSvnWriteInterface(GitReadOnlyMixin, GitSvnInterface):
+    # Find remote branch where current commit will appear. Assumes everything
+    # to be merge-free (unique parents).
+    branch = None
+    hsh = "HEAD"
+    while not branch:
+      branch = self.step.GitRemoteContains(hsh)
+      hsh += "^"

[agable, 2014/09/29 09:49:11]

Cute. Might be better to actually query Git for the parent of the commit and
directly reference that instead. Clearer logging too.

[Michael Achenbach, 2014/09/29 10:46:25]

Done. Changed the semantics slightly as HEAD always refers to a local commit
only.

+
+    # Wait for the commit to appear. Assumes unique commit message titles (this
+    # is the case for all automated merge and push commits - also no title is
+    # the prefix of another title).
+    commit = None
+    for wait_interval in [3, 5, 10, 30]:
+      self.step.Git("fetch")
+      commit = self.step.GitLog(n=1, format="%H", grep=title, branch=branch)

[agable, 2014/09/29 09:49:11]

This n=1 is dangerous -- what if two commits get replicated in rapid succession?

[Michael Achenbach, 2014/09/29 10:46:25]

But shouldn't the grep on the unique title take care of this? Is there a better
command then git log for achieving the same thing?

+      if commit:
+        break
+      print("The commit is not replicated on git. Waiting for %s seconds." %

[agable, 2014/09/29 09:49:11]

nit: "...has not replicated to..."

[Michael Achenbach, 2014/09/29 10:46:25]

Done.

+            wait_interval)
+      self.step._side_effect_handler.Sleep(wait_interval)
+
+    if not commit:
+      self.step.Die("Couldn't determine commit for setting the tag. Maybe the "
+               "git updater is lacking behind?")

[agable, 2014/09/29 09:49:11]

nit: "lagging"

[agable, 2014/09/29 09:49:11]

nit: indentation

[Michael Achenbach, 2014/09/29 10:46:24]

Done.

[Michael Achenbach, 2014/09/29 10:46:24]

Done.

+
+    self.step.Git("tag %s %s" % (tag, commit))

[agable, 2014/09/29 09:49:11]

The fact that this takes args as a single string instead of a list of tokens
makes me very sad.

[Michael Achenbach, 2014/09/29 10:46:24]

I'm sad too. But I'll address this in a separate refactoring CL.

+    self.step.Git("push origin %s" % tag)
+
+
+class GitReadSvnWriteInterface(GitTagsOnlyMixin, GitSvnInterface):
   pass
 
 
 VC_INTERFACES = {
   "git_svn": GitSvnInterface,
   "git_read_svn_write": GitReadSvnWriteInterface,
 }
 
 
 class Step(GitRecipesMixin):
@@ skipping 446 matching lines @@
     for (number, step_class) in enumerate(step_classes):
       steps.append(MakeStep(step_class, number, self._state, self._config,
                             options, self._side_effect_handler))
     for step in steps[options.step:]:
       if step.Run():
         return 0
     return 0
 
   def Run(self, args=None):
     return self.RunSteps(self._Steps(), args)