|
|
Created:
6 years, 2 months ago by Mayur Kankanwadi Modified:
6 years, 2 months ago CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionRemove --disable-desktop-notifications flag.
This CL has chromium side of the changes made to remove the
--disable-desktop-notifications flag.
BUG=414270
Committed: https://crrev.com/826018b1b07d7af4509b3f19a30a78348c1ec02c
Cr-Commit-Position: refs/heads/master@{#298678}
Patch Set 1 #Patch Set 2 : Reverted changes in blink, keeping notifications on, disabled the feature for Android only. #Patch Set 3 : Rebase _07 oct_ done. #Patch Set 4 : Rebased code. #Patch Set 5 : Added self to AUTHORS file. #
Messages
Total messages: 41 (20 generated)
mayurk.vk@samsung.com changed reviewers: + dewittj@chromium.org, peter@chromium.org
Chromium side changes. PTAL.
On 2014/09/26 12:04:12, Mayur Kankanwadi wrote: > Chromium side changes. > PTAL. lgtm for PS2. It might be worthwhile to note that Android support will just be tied under the --enable-experimental-web-platform-features flag.
On 2014/09/26 14:52:22, Peter Beverloo wrote: > On 2014/09/26 12:04:12, Mayur Kankanwadi wrote: > > Chromium side changes. > > PTAL. > > lgtm for PS2. > > It might be worthwhile to note that Android support will just be tied under the > --enable-experimental-web-platform-features flag. Thanks Peter. dewittj : would be great to hear from you regarding this patch. Regards.
On 2014/09/29 06:39:08, Mayur Kankanwadi wrote: > On 2014/09/26 14:52:22, Peter Beverloo wrote: > > On 2014/09/26 12:04:12, Mayur Kankanwadi wrote: > > > Chromium side changes. > > > PTAL. > > > > lgtm for PS2. > > > > It might be worthwhile to note that Android support will just be tied under > the > > --enable-experimental-web-platform-features flag. > > Thanks Peter. > > dewittj : would be great to hear from you regarding this patch. > Regards. Rubber stamp lgtm
On 2014/09/29 06:47:04, dewittj wrote: > On 2014/09/29 06:39:08, Mayur Kankanwadi wrote: > > On 2014/09/26 14:52:22, Peter Beverloo wrote: > > > On 2014/09/26 12:04:12, Mayur Kankanwadi wrote: > > > > Chromium side changes. > > > > PTAL. > > > > > > lgtm for PS2. > > > > > > It might be worthwhile to note that Android support will just be tied under > > the > > > --enable-experimental-web-platform-features flag. > > > > Thanks Peter. > > > > dewittj : would be great to hear from you regarding this patch. > > Regards. > > Rubber stamp lgtm Thanks, dewittj. Can you also let me know which bots to run for this patch?
The CQ bit was checked by mayurk.vk@samsung.com
The CQ bit was unchecked by mayurk.vk@samsung.com
The CQ bit was checked by mayurk.vk@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607843002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
mayurk.vk@samsung.com changed reviewers: + creis@chromium.org, jam@chromium.org, sky@chromium.org
On 2014/09/29 07:57:56, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux > (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Hi jam, sky & cries, Can you please review the changes once? The submit bots are stuck on OWNER's approval. Thanks.
lgtm
The CQ bit was checked by mayurk.vk@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607843002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by mayurk.vk@samsung.com
The CQ bit was unchecked by mayurk.vk@samsung.com
The CQ bit was checked by mayurk.vk@samsung.com
The CQ bit was unchecked by mayurk.vk@samsung.com
The CQ bit was checked by mayurk.vk@samsung.com
The CQ bit was unchecked by mayurk.vk@samsung.com
Hi Peter, jam, dewittj, Please LGTM this again. Just rebased again, as the last patch failed in presubmit. Thanks a lot. --Mayur Kankanwadi.
On 2014/10/07 07:42:26, Mayur Kankanwadi wrote: > Hi Peter, jam, dewittj, > Please LGTM this again. > Just rebased again, as the last patch failed in presubmit. > Thanks a lot. > --Mayur Kankanwadi. You don't need further LGTMs for rebases, but have one anyway: lgtm Go right ahead! :-)
The CQ bit was checked by mayurk.vk@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607843002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/65249) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
On 2014/10/07 07:54:13, Peter Beverloo wrote: > On 2014/10/07 07:42:26, Mayur Kankanwadi wrote: > > Hi Peter, jam, dewittj, > > Please LGTM this again. > > Just rebased again, as the last patch failed in presubmit. > > Thanks a lot. > > --Mayur Kankanwadi. > > You don't need further LGTMs for rebases, but have one anyway: > lgtm > > Go right ahead! :-) Thanks. :) Anyways looks like this rebase has failed. Have to try again. :(
The CQ bit was checked by mayurk.vk@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607843002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was unchecked by mayurk.vk@samsung.com
The CQ bit was checked by mayurk.vk@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607843002/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 47c65402ac967488cee476e9f081312fbe0ccc76
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/826018b1b07d7af4509b3f19a30a78348c1ec02c Cr-Commit-Position: refs/heads/master@{#298678} |