Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 607843002: Remove --disable-desktop-notifications flag. (Closed)

Created:
6 years, 2 months ago by Mayur Kankanwadi
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove --disable-desktop-notifications flag. This CL has chromium side of the changes made to remove the --disable-desktop-notifications flag. BUG=414270 Committed: https://crrev.com/826018b1b07d7af4509b3f19a30a78348c1ec02c Cr-Commit-Position: refs/heads/master@{#298678}

Patch Set 1 #

Patch Set 2 : Reverted changes in blink, keeping notifications on, disabled the feature for Android only. #

Patch Set 3 : Rebase _07 oct_ done. #

Patch Set 4 : Rebased code. #

Patch Set 5 : Added self to AUTHORS file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M AUTHORS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 41 (20 generated)
Mayur Kankanwadi
Chromium side changes. PTAL.
6 years, 2 months ago (2014-09-26 12:04:12 UTC) #2
Peter Beverloo
On 2014/09/26 12:04:12, Mayur Kankanwadi wrote: > Chromium side changes. > PTAL. lgtm for PS2. ...
6 years, 2 months ago (2014-09-26 14:52:22 UTC) #3
Mayur Kankanwadi
On 2014/09/26 14:52:22, Peter Beverloo wrote: > On 2014/09/26 12:04:12, Mayur Kankanwadi wrote: > > ...
6 years, 2 months ago (2014-09-29 06:39:08 UTC) #4
dewittj
On 2014/09/29 06:39:08, Mayur Kankanwadi wrote: > On 2014/09/26 14:52:22, Peter Beverloo wrote: > > ...
6 years, 2 months ago (2014-09-29 06:47:04 UTC) #5
Mayur Kankanwadi
On 2014/09/29 06:47:04, dewittj wrote: > On 2014/09/29 06:39:08, Mayur Kankanwadi wrote: > > On ...
6 years, 2 months ago (2014-09-29 06:51:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607843002/20001
6 years, 2 months ago (2014-09-29 07:51:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14041)
6 years, 2 months ago (2014-09-29 07:57:56 UTC) #12
Mayur Kankanwadi
On 2014/09/29 07:57:56, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-09-29 09:11:37 UTC) #14
jam
lgtm
6 years, 2 months ago (2014-10-01 21:22:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607843002/20001
6 years, 2 months ago (2014-10-02 05:13:18 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14896)
6 years, 2 months ago (2014-10-02 05:21:16 UTC) #19
Mayur Kankanwadi
Hi Peter, jam, dewittj, Please LGTM this again. Just rebased again, as the last patch ...
6 years, 2 months ago (2014-10-07 07:42:26 UTC) #26
Peter Beverloo
On 2014/10/07 07:42:26, Mayur Kankanwadi wrote: > Hi Peter, jam, dewittj, > Please LGTM this ...
6 years, 2 months ago (2014-10-07 07:54:13 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607843002/40001
6 years, 2 months ago (2014-10-07 08:29:43 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/75910) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/65249) android_arm64_dbg_recipe ...
6 years, 2 months ago (2014-10-07 08:34:44 UTC) #31
Mayur Kankanwadi
On 2014/10/07 07:54:13, Peter Beverloo wrote: > On 2014/10/07 07:42:26, Mayur Kankanwadi wrote: > > ...
6 years, 2 months ago (2014-10-07 08:34:57 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607843002/60001
6 years, 2 months ago (2014-10-08 08:28:17 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16235)
6 years, 2 months ago (2014-10-08 08:35:59 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607843002/80001
6 years, 2 months ago (2014-10-08 09:08:35 UTC) #39
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 47c65402ac967488cee476e9f081312fbe0ccc76
6 years, 2 months ago (2014-10-08 10:08:16 UTC) #40
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 10:09:05 UTC) #41
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/826018b1b07d7af4509b3f19a30a78348c1ec02c
Cr-Commit-Position: refs/heads/master@{#298678}

Powered by Google App Engine
This is Rietveld 408576698