Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 607823002: Add a mechanism for python test server to exit (Closed)

Created:
6 years, 2 months ago by kaliamoorthi
Modified:
6 years, 2 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a mechanism for python test server to exit This CL adds a mechanism which can be used to make the python test server exit. BUG=417684 Committed: https://crrev.com/6699be349706926722f7834ef1158740203eb556 Cr-Commit-Position: refs/heads/master@{#296920}

Patch Set 1 #

Patch Set 2 : Fixes nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/policy/test/policy_testserver.py View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kaliamoorthi
PTAL
6 years, 2 months ago (2014-09-26 09:16:50 UTC) #2
kaliamoorthi
I fixed the issues we discussed offline.
6 years, 2 months ago (2014-09-26 09:43:56 UTC) #3
kaliamoorthi
PTAL
6 years, 2 months ago (2014-09-26 09:44:05 UTC) #4
pastarmovj
lgtm
6 years, 2 months ago (2014-09-26 11:18:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607823002/20001
6 years, 2 months ago (2014-09-26 11:24:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as cc7e861ddb870db626703c9a1d1d4e19b618e418
6 years, 2 months ago (2014-09-26 11:58:09 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 11:58:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6699be349706926722f7834ef1158740203eb556
Cr-Commit-Position: refs/heads/master@{#296920}

Powered by Google App Engine
This is Rietveld 408576698