Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 607803002: IAccessible2 state not defined for input type checkbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@323161exposeinputtypes
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_win.cc
diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc
index ff239430f396c979c0644cf9aabd8e6b5a260ec2..8fcd6449c2eae5d28fedf87a682eb8cf12f2b5a7 100644
--- a/content/browser/accessibility/browser_accessibility_win.cc
+++ b/content/browser/accessibility/browser_accessibility_win.cc
@@ -3423,6 +3423,15 @@ void BrowserAccessibilityWin::InitRoleAndState() {
break;
case ui::AX_ROLE_CHECK_BOX:
ia_role_ = ROLE_SYSTEM_CHECKBUTTON;
+ bool is_aria_checked_defined;
+ bool is_mixed_check;
+ if (GetAriaTristate("aria-checked",
+ &is_aria_checked_defined, &is_mixed_check)) {
+ ia_state_ |= STATE_SYSTEM_CHECKED;
dmazzoni 2014/09/29 05:49:51 This seems wrong - you're setting it to CHECKED wh
shreeramk 2014/09/29 05:58:32 GetAriaTristate() compares the value of the first
+ ia2_state_ = IA2_STATE_CHECKABLE;
+ if (is_mixed_check)
+ ia_state_ |= STATE_SYSTEM_MIXED;
+ }
break;
case ui::AX_ROLE_COLOR_WELL:
ia_role_ = ROLE_SYSTEM_CLIENT;

Powered by Google App Engine
This is Rietveld 408576698