Update GrRecordReplaceDraw to use SkTDynamicHash & add ReplaceDraw

Update GrRecordReplaceDraw to use SkTDynamicHash & add ReplaceDraw

Having hoisted layers from different pictures invalidates the assumptions of the old GrReplacements object. This is fixed by switching to a SkTDynamicHash-based back-end.

Sub-picture-layers also require that the replacement drawing occur for the sub-pictures too. The ReplaceDraw object is added to make this happen and limit the replacement lookup to saveLayer draw commands.

This is split out of (Fix sub-picture layer rendering bugs - https://codereview.chromium.org/597293002/).

BUG=skia:2315
Committed: https://skia.googlesource.com/skia/+/68cd2aa797f707a9847f8eba0758787cafd43e43

[robertphillips, 2014-09-29 18:48:46]

robertphillips@google.com changed reviewers:
+ egdaniel@google.com

[robertphillips, 2014-09-30 16:45:10]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2014-09-30 17:47:17]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-09-30 17:47:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607763008/20001

[commit-bot: I haz the power, 2014-09-30 17:48:00]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-09-30 23:47 UTC

[commit-bot: I haz the power, 2014-09-30 17:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 17:48:04]

Presubmit check for 607763008-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[robertphillips, 2014-10-01 12:00:10]

ping

[bsalomon, 2014-10-01 13:20:28]

lgtm

[egdaniel, 2014-10-01 13:28:12]

Nits

https://codereview.chromium.org/607763008/diff/20001/src/gpu/GrRecordReplaceD...
File src/gpu/GrRecordReplaceDraw.cpp (right):

https://codereview.chromium.org/607763008/diff/20001/src/gpu/GrRecordReplaceD...
src/gpu/GrRecordReplaceDraw.cpp:12: #include "SkCanvasPriv.h"
Alphabetize

https://codereview.chromium.org/607763008/diff/20001/src/gpu/GrRecordReplaceD...
src/gpu/GrRecordReplaceDraw.cpp:34: GrReplacements::lookupByStart(uint32_t
pictureID, size_t start, const SkMatrix& ctm) const {
is it normal to have a newline between the return type and function name? Does
it just not fit or look back if we newline the arguments?

[robertphillips, 2014-10-01 16:04:24]

https://codereview.chromium.org/607763008/diff/20001/src/gpu/GrRecordReplaceD...
File src/gpu/GrRecordReplaceDraw.cpp (right):

https://codereview.chromium.org/607763008/diff/20001/src/gpu/GrRecordReplaceD...
src/gpu/GrRecordReplaceDraw.cpp:12: #include "SkCanvasPriv.h"
On 2014/10/01 13:28:12, egdaniel wrote:
> Alphabetize

Done.

https://codereview.chromium.org/607763008/diff/20001/src/gpu/GrRecordReplaceD...
src/gpu/GrRecordReplaceDraw.cpp:34: GrReplacements::lookupByStart(uint32_t
pictureID, size_t start, const SkMatrix& ctm) const {
On 2014/10/01 13:28:12, egdaniel wrote:
> is it normal to have a newline between the return type and function name? Does
> it just not fit or look back if we newline the arguments?

Done.

[robertphillips, 2014-10-01 16:04:36]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-10-01 16:05:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607763008/50001

[commit-bot: I haz the power, 2014-10-01 16:07:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-01 16:07:23]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[robertphillips, 2014-10-01 16:12:20]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-10-01 16:12:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607763008/70001

[commit-bot: I haz the power, 2014-10-01 16:24:09]

Committed patchset #5 (id:70001) as 68cd2aa797f707a9847f8eba0758787cafd43e43